Skip to content

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Apr 4, 2025

Description

This PR adds support for tagging Containers

Supporting information

Testing instructions


Private ref: FAL-4111

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 4, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 4, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 4, 2025
@rpenido rpenido changed the title Rpenido/fal 4111/units tags and collections feat: container support for tags and collections Apr 4, 2025
@rpenido rpenido force-pushed the rpenido/fal-4111/units-tags-and-collections branch 6 times, most recently from 587ca9a to 0150358 Compare April 4, 2025 23:46
@rpenido rpenido changed the title feat: container support for tags and collections feat: container support for tags Apr 5, 2025
@rpenido rpenido force-pushed the rpenido/fal-4111/units-tags-and-collections branch from 0150358 to cd122f6 Compare April 7, 2025 19:00
@rpenido rpenido changed the title feat: container support for tags feat: container support for tags [FC-0083] Apr 7, 2025
@rpenido rpenido force-pushed the rpenido/fal-4111/units-tags-and-collections branch 2 times, most recently from 26ae05b to 0a33daa Compare April 7, 2025 19:34
@rpenido rpenido marked this pull request as ready for review April 7, 2025 19:41
@rpenido rpenido force-pushed the rpenido/fal-4111/units-tags-and-collections branch from 0a33daa to 429c606 Compare April 7, 2025 19:51
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Apr 7, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Apr 7, 2025
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 a few nits about duplicate code, but working well!

  • I tested this while testing openedx/frontend-app-authoring#1782
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation -- removes obsolete comments, documents new methods
  • User-facing strings are extracted for translation N/A

@rpenido rpenido force-pushed the rpenido/fal-4111/units-tags-and-collections branch 2 times, most recently from 36b72f2 to b5c69c6 Compare April 8, 2025 16:07
@rpenido rpenido force-pushed the rpenido/fal-4111/units-tags-and-collections branch from b5c69c6 to 9c17d9a Compare April 8, 2025 16:20
@rpenido rpenido closed this Apr 8, 2025
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Apr 8, 2025
@rpenido rpenido reopened this Apr 8, 2025
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Beautiful, thank you @rpenido !

  • I tested this using openedx/frontend-app-authoring#1782 testing instructions
  • I read through the code
  • I checked for accessibility issues N/A
  • Updates documentation -- removes obsolete code comments, updates method docs
  • User-facing strings are extracted for translation N/A

Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good 👍

  • I tested this: (Added/removed tags from container)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@rpenido rpenido marked this pull request as draft April 9, 2025 12:01
@rpenido rpenido marked this pull request as ready for review April 9, 2025 17:21
@navinkarkera navinkarkera merged commit a0d9931 into openedx:master Apr 10, 2025
49 checks passed
@navinkarkera navinkarkera deleted the rpenido/fal-4111/units-tags-and-collections branch April 10, 2025 05:44
irtazaakram pushed a commit that referenced this pull request Apr 10, 2025
* feat: container tag support

* fix: fixes from review

* docs: fix typo
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

farhan pushed a commit that referenced this pull request Apr 17, 2025
* feat: container tag support

* fix: fixes from review

* docs: fix typo
tonybusa pushed a commit to tonybusa/edx-platform that referenced this pull request Apr 23, 2025
* feat: container tag support

* fix: fixes from review

* docs: fix typo
UsamaSadiq pushed a commit that referenced this pull request May 14, 2025
* feat: container tag support

* fix: fixes from review

* docs: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants