-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: container support for tags [FC-0083] #36484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: container support for tags [FC-0083] #36484
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
587ca9a to
0150358
Compare
0150358 to
cd122f6
Compare
26ae05b to
0a33daa
Compare
0a33daa to
429c606
Compare
pomegranited
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 a few nits about duplicate code, but working well!
- I tested this while testing openedx/frontend-app-authoring#1782
- I read through the code
-
I checked for accessibility issuesN/A - Includes documentation -- removes obsolete comments, documents new methods
-
User-facing strings are extracted for translationN/A
36b72f2 to
b5c69c6
Compare
b5c69c6 to
9c17d9a
Compare
pomegranited
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Beautiful, thank you @rpenido !
- I tested this using openedx/frontend-app-authoring#1782 testing instructions
- I read through the code
-
I checked for accessibility issuesN/A - Updates documentation -- removes obsolete code comments, updates method docs
-
User-facing strings are extracted for translationN/A
navinkarkera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Looks good 👍
- I tested this: (Added/removed tags from container)
- I read through the code
- I checked for accessibility issues
- Includes documentation
* feat: container tag support * fix: fixes from review * docs: fix typo
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
* feat: container tag support * fix: fixes from review * docs: fix typo
* feat: container tag support * fix: fixes from review * docs: fix typo
* feat: container tag support * fix: fixes from review * docs: fix typo
Description
This PR adds support for tagging Containers
Supporting information
Testing instructions
Private ref: FAL-4111