-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Changing Student Anon ID Dump to return Course Specific IDs. #3703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm concerned about this change. Researchers might be relying on the anonymous IDs in these spreadsheets to be consistent over time. I'm also pretty sure there are XModules that are still using IDs that are not unique to a particular course. I think adding an extra column would be safer. |
|
++ @wedaly |
|
I could definitely add another column for Course Specific Anonymized User IDs. It means I'll likely have to make separate queries. @cpennington does that sound good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually just put the return value in these definitions:
@patch.object(instructor.views.api, 'anonymous_id_for_user', Mock(return_value=41))
|
|
Hello, may I ask @brianhw / @rocha / @mulby whether this new format is parallel to the Anonymous ID info we are currently exporting as part of the research data packages?
Thank you |
|
@stroilova - we are not currently exporting this ID. See https://edx-wiki.atlassian.net/browse/AN-320. We export database tables in a very specific format, I doubt we would want to change that for this reason. Also we typically try to mirror the table schema as closely as possible, so we typically aren't joining in columns from other tables etc, which would be necessary to add this information to the current file. |
|
👍 |
Changing Student Anon ID Dump to return Course Specific IDs.
|
Ah ok. That makes sense, thank you @mulby . On Wed, May 14, 2014 at 3:04 PM, Stephen Sanchez
|
Tests verified, manually tested.
@cpennington Regarding our conversation this morning around the CSV action to pull anonymous user IDs, this PR would change the CSV to include the course-specific IDs.
@Lyla-Fischer This change alters the contract of what is returned by this instructor dashboard action, is there any risk of impacting staff / instructors who may rely on the old Anonymous IDs?
@wedaly