refactor: convert function based view to class based #37047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mubbsharanwar
force-pushed
the
mubbshar/issue-37032
branch
4 times, most recently
from
05a1dec to
28fcb90
Compare
awais786
reviewed
Jul 23, 2025
mubbsharanwar
force-pushed
the
mubbshar/issue-37032
branch
from
3cfdcd8 to
8b7de92
Compare
Contributor
|
Please read the discussion details on issue #37036 |
mubbsharanwar
force-pushed
the
mubbshar/issue-37032
branch
14 times, most recently
from
8242a76 to
a5cb0cd
Compare
mubbsharanwar
force-pushed
the
mubbshar/issue-37032
branch
2 times, most recently
from
54164a9 to
75125c8
Compare
mubbsharanwar
force-pushed
the
mubbshar/issue-37032
branch
from
75125c8 to
95db5fb
Compare
feanil
reviewed
Aug 4, 2025
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Generally looks good, just one question about an unnecessary refactor that makes the PR harder to review.
feanil
reviewed
Aug 5, 2025
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Sorry for the piece meal review.
feanil
approved these changes
Aug 5, 2025
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert the function-based certificate view to a class-based view.
Supporting information
Issue #37034
Testing instructions
Go to course studio -> Settings dropdown -> certificates