-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: refresh-saml-metadata beat task path fixed #37080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @marslanabdulrauf! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
kdmccormick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix. Looks like this was a I typo I introduced myself several years ago!
Before I merge, could you add some more supporting information to the PR description? The link you provided is private to MIT ODL.
|
Thanks @kdmccormick |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This PR fixes the task path in the Celery beat settings for the refresh-saml-metadata scheduled task. We had previously added the fetch_saml_metadata task to the Celery beat schedule to run periodically (default: every 24 hours). However, due to a typo in the task path, Celery workers were throwing errors. This fix corrects the task path so the schedule can run as intended.
This PR fixes the task path in the Celery beat settings for the refresh-saml-metadata scheduled task. We had previously added the fetch_saml_metadata task to the Celery beat schedule to run periodically (default: every 24 hours). However, due to a typo in the task path, Celery workers were throwing errors. This fix corrects the task path so the schedule can run as intended.
* fix: refresh-saml-metadata beat task path fixed (openedx#37257) Backports: openedx#37080 * [Teak] feat: Show disabled edit button and tooltip to component in units from libraries [FC-0097] (openedx#37282) * Show disabled edit button and tooltip to component in units from libraries * fix: intermittent "utils attribute not found" issue in webpack_loader (openedx#37306) Backports: openedx#37109 * fix: find and match enterprise user only if enterprise is enabled * chore(deps): openedx-forum upgraded using make upgrade-package * chore: ran make compile requirements --------- Co-authored-by: Muhammad Arslan <arslan.abdulrauf@arbisoft.com> Co-authored-by: Chris Chávez <xnpiochv@gmail.com> Co-authored-by: Muhammad Anas <88967643+Anas12091101@users.noreply.github.com>
Description
This PR fixes the task path in the Celery beat settings for the
refresh-saml-metadatascheduled task.We had previously added the
fetch_saml_metadatatask to the Celery beat schedule to run periodically (default: every 24 hours). However, due to a typo in the task path, Celery workers were throwing errors. This fix corrects the task path so the schedule can run as intended.Supporting information
https://github.com/mitodl/hq/issues/6702