-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[DRAFT] Unit Prerequisites Lost During Course Export/Import #37095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @haftamuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@haftamuk Try adding |
| logging.warning(f'INSPECTING-LOG get_prereq_metadata type is = %s', type(self)) | ||
| logging.warning(f'INSPECTING-LOG get_prereq_metadata vars is = %s', vars(self)) | ||
|
|
||
| gating_service = self.runtime.service(self, 'gating') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cup0fCoffee This always returns an empty object.
| logging.warning(f'INSPECTING-LOG course_id is = %s', course_id) | ||
| logging.warning(f'INSPECTING-LOG content_id is = %s', content_id) | ||
|
|
||
| milestone = self.get_prereq_metadata(course_id, content_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values to be exported will be populated from the results found at milestone object. @Cup0fCoffee
|
Hi @haftamuk! Just checking to see if this pull request is still in progress? |
|
Closing for now due to inactivity. Can reopen if needed. Thanks! |
|
@mphilbrick211 I am planning to put more time in this the coming days! If you may kindly reopen this |
|
@haftamuk Would you be able to create a new pull request? I wasn't able to reopen this one. Looks like this one can't be re-opened because the branch on your end was removed. Sorry for any confusion. |
|
|
@mphilbrick211 Yes. here is the new PR I am working on! Kindly if you can conduct a review on it or facilitate to engage someone to do a review. The bug requires some data formatting considerations that require feedback in the early stages i.e. on data export before we work on import and course re-run! Thank you |
This PR introduces support for subsection (sequential) prerequisites in the OLX course format. Course authors can now define prerequisite relationships between subsections with configurable completion criteria including minimum score and completion percentage requirements.
Problem Statement
Currently, Open edX lacks the ability to define prerequisite relationships between subsections at the OLX level. This prevents course authors from enforcing learning pathways where students must complete certain subsections before accessing others, which is crucial for structured learning experiences.
Proposed Solution
Supporting information