-
Notifications
You must be signed in to change notification settings - Fork 4.2k
chore: update @edx/brand dependency to new package @openedx/brand-openedx #37105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update @edx/brand dependency to new package @openedx/brand-openedx #37105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I'm concerned about the size of the package-lock.json change-- that seems way to high of a line count for such a small package.json change. What command did you run to regenerate package-lock.json?
|
@ttak-apphelix: Next steps:
|
@kdmccormick I was deleting node_module folder but by mistake I added package-lock.json file also. I have corrected that change and now it shows minimal changes in package-lock.json file |
|
kdmccormick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the code looks good to me. I haven't tested, so please make sure some basic smoke-testing has been done before merging.
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
…nedx (openedx#37105) * chore: update @edx/brand dependency to new package @openedx/brand-openedx * Revert package-lock.json * fix: updated package-lock.json
Description
This PR replaces brand-edx.org with openedx theme and adds it to the package file indirectly via aliasing.
Supporting information
Issue Link: edx/edx-arch-experiments#943
Link to the PR which is associated with the same issue
edx/configuration#230