Skip to content

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Aug 14, 2025

Description

  • Refactor upstream links summary to add the top-level parent logic
  • Update the filter_links function to annotate each result with ready_to_sync_from_children
  • Which edX user roles will this change impact? "Course Author".

Supporting information

Testing instructions

  • Create a new library and a new course.
  • In the library, you need to create this nested structure: Section > Subsection > Unit > Component.
  • Publish the library.
  • In the course:
    • Import the Section from the library.
    • Create a simple Section. In this section:
      • Import the Subsection from the library.
      • Create a simple Subsection. In this subsection:
        • Import the Unit from the library.
        • Create a simple Unit. In this unit:
          • Import the Component from the library.
  • Go to Content > Library Updates.
  • Verify the summary.
  • Go to the library, update the Section name, and publish it.
  • Go to Content > Library Updates. Verify that you only see the Section card to update. Click on Update
  • Go to the library, update the Subsection name, and publish it.
  • Go to Content > Library Updates. Verify the summary
  • Update all.
  • Go to the library, update the Unit name, and publish it.
  • Go to Content > Library Updates. Verify the summary
  • Update all.
  • Go to the library, update the Component name, and publish it.
  • Go to Content > Library Updates. Verify the summary

Deadline

None

Other information

N/A

…logic

* Update the filter_links function to anotate each result with ready_to_sync_from_children
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 14, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 14, 2025
@ChrisChV ChrisChV changed the title refactor: Refactor upstream links sumary to add the top-level parent … refactor: Refactor upstream links sumary to add the top-level parent logiclo [FC-0097] Aug 15, 2025
@ChrisChV ChrisChV changed the title refactor: Refactor upstream links sumary to add the top-level parent logiclo [FC-0097] refactor: Refactor upstream links sumary to add the top-level parent logic [FC-0097] Aug 15, 2025
@ChrisChV ChrisChV changed the title refactor: Refactor upstream links sumary to add the top-level parent logic [FC-0097] refactor: Refactor upstream links summary to add the top-level parent logic [FC-0097] Aug 15, 2025
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV This looks good, thanks!

Should we combine this with #37217 and test them together before merging?

@ChrisChV
Copy link
Contributor Author

Should we combine this with #37217 and test them together before merging?

I don't see it as necessary; I think those functionalities are separate. But if you see it necessary, it doesn't hurt to do those tests.

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor questions/suggestions but I don't need to re-review.

@ChrisChV ChrisChV enabled auto-merge (squash) August 18, 2025 23:46
@ChrisChV ChrisChV merged commit a1195ef into openedx:master Aug 19, 2025
48 checks passed
@ChrisChV ChrisChV deleted the chris/FAL-4231-update-links-summary branch August 19, 2025 00:01
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Aug 19, 2025
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

salman2013 pushed a commit to salman2013/edx-platform that referenced this pull request Sep 10, 2025
… logic [FC-0097] (openedx#37208)

- Refactor upstream links summary to add the top-level parent logic
- Update the `filter_links` function to annotate each result with `ready_to_sync_from_children`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants