chore: remove outdated JWT auth related settings #37373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unused settings relating to JWT authentication. These settings were originally added here and here.
I originally thought the removal of these settings was related to the effort in this issue, but a closer reading revealed that issue is talking about the settings in the
JWT_AUTHsetting.The settings removed in this PR appear to be redundant, unused duplicates of settings in the JWT_AUTH dictionary. I was unable to find any references in edx-platform, edx-drf-extensions, or drf-jwt where these settings were access at the top level (not through
JWT_AUTH). Searching the openedx org on GitHub didn't turn up anything that used these.Testing instructions
Remove these settings and unit tests still pass. Search these settings in relevant repos to verify they are not used.
Other considerations
Is there anywhere else that needs to be searched? Would this removal need to be categorized as a breaking change?