feanil/fix branding redirect loop #37510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are out of date and while they still work with the proxy object we don't need them anymore. Just look up the setting directly.
If ENABLE_MKTG_SITE is True, MKTG_URLS['ROOT'] must be set. However if it is set to the same value as the LMS_ROOT_URL (which points to this view), you can end up in an infinite redirect loop. If the two URLs do match, don't redirect, just fall through to the content that this page would have responded with instead.
feanil
force-pushed
the
feanil/fix_branding_redirect_loop
branch
from
1e5b7f8 to
a0ab489
Compare
ormsbee
approved these changes
Oct 21, 2025
Contributor
|
I see. You are leaving the legacy code in place for now. Thanks. |
Contributor
Author
|
Longer term I think all of the implementation in this year is going to be replaced with just the redirects to the new MFE. In that situation I would expect you guys to have your own either catalog, MFE or other landing page that you want to send people to. See #36785 for more details. |
Contributor
|
Thanks @feanil. We'll see how this shakes out during the next named release. I'm unclear whether or not edge will want the new MFE, etc. But, that's an issue for another time. I think we're all set right now with your implementation. |
ktyagiapphelix2u
pushed a commit
to edx/edx-platform
that referenced
this pull request
Oct 29, 2025
…irect_loop feanil/fix branding redirect loop
Akanshu-2u
pushed a commit
to edx/edx-platform
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ENABLE_MKTG_SITE is True, MKTG_URLS['ROOT'] must be set. However if
it is set to the same value as the LMS_ROOT_URL (which points to this
view), you can end up in an infinite redirect loop. If the two URLs do
match, don't redirect, just fall through to the content that this page
would have responded with instead.
This impacts #37053 since that would cause the ENABLE_MKTG_SITE=True path to always be called.