fix: do not autogenerate username if coming through SSO #37522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zamanafzal
approved these changes
Oct 22, 2025
haftamuk
pushed a commit
to haftamuk/edx-platform
that referenced
this pull request
Nov 3, 2025
Co-authored-by: Sameen Fatima <sameen.fatima@A006-01036.local>
sameenfatima78
added a commit
to edx/edx-platform
that referenced
this pull request
Nov 5, 2025
Co-authored-by: Sameen Fatima <sameen.fatima@A006-01036.local>
sameenfatima78
added a commit
to edx/edx-platform
that referenced
this pull request
Nov 5, 2025
fix: do not autogenerate username if coming through SSO (openedx#37522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Username is not being picked up from SAML response for enterprise learners due to
is_auto_generated_username_enabledbeing enabled.JIRA:
Fix:
Verify if we are receiving any username value in the response payload and give it preference over the auto-generated username. This approach is similar to how it is handled in the Registration flow: https://github.com/openedx/edx-platform/pull/34562/files#diff-10e2a9ce44f5002369208fb96f3f95512c889dd126dfd416bee3ac3807f3358fR581