-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[FC-0099] feat: assign library roles after successful library creation #37532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| NO_ACCESS = None | ||
|
|
||
|
|
||
| ACCESS_LEVEL_TO_LIBRARY_ROLE = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I have a unittest I need to push :) |
00dc12f to
ede1472
Compare
bmtcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
rodmgwgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
MaferMazu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
This PR grants the library_admin role to a user after they create a content library. The assigned role matches the current access level defined in the migration plan: https://openedx.atlassian.net/wiki/spaces/OEPM/pages/5252317270/Libraries+Roles+and+Permissions+Migration+Plan. This ensures the user keeps the same level of access in the new authorization framework.
This PR only handles the role assignment. The actual permission checks for this new role will be added in a separate PR, so this one has no functional effect yet.
The upcoming PR that introduces these checks, along with other roles related to the Administration Console experience, is here: #37501. The integration with the Authoring MFE, where this role will take effect, is still a work in progress. I'll link it here once it's ready.
Supporting information
openedx/openedx-authz#111 (comment)
https://github.com/openedx/openedx-authz/?tab=readme-ov-file#openedx-authz
https://discuss.openedx.org/t/depr-libraries-roles-and-permission-system/17392
Testing instructions