Skip to content

Conversation

@mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Oct 23, 2025

Description

This PR grants the library_admin role to a user after they create a content library. The assigned role matches the current access level defined in the migration plan: https://openedx.atlassian.net/wiki/spaces/OEPM/pages/5252317270/Libraries+Roles+and+Permissions+Migration+Plan. This ensures the user keeps the same level of access in the new authorization framework.

This PR only handles the role assignment. The actual permission checks for this new role will be added in a separate PR, so this one has no functional effect yet.

The upcoming PR that introduces these checks, along with other roles related to the Administration Console experience, is here: #37501. The integration with the Authoring MFE, where this role will take effect, is still a work in progress. I'll link it here once it's ready.

Supporting information

openedx/openedx-authz#111 (comment)
https://github.com/openedx/openedx-authz/?tab=readme-ov-file#openedx-authz
https://discuss.openedx.org/t/depr-libraries-roles-and-permission-system/17392

Testing instructions

  1. Login into studio with course creator permissions, then create a library from scratch
  2. You can use the openedx-authz REST API to get all roles for users, and review whether the role was assigned to the user you just used: http://local.openedx.io:8000/api-docs/#/authz/authz_v1_roles_users_list, where scope is the ID of the library you just created

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 23, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 23, 2025

Thanks for the pull request, @mariajgrimaldi!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 23, 2025
@mariajgrimaldi mariajgrimaldi moved this to In Progress in RBAC AuthZ Board Oct 23, 2025
@mariajgrimaldi mariajgrimaldi changed the title feat: assign library roles after successful library creation [FC-0099] feat: assign library roles after successful library creation Oct 23, 2025
NO_ACCESS = None


ACCESS_LEVEL_TO_LIBRARY_ROLE = {
Copy link
Member Author

@mariajgrimaldi mariajgrimaldi Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmakowski1123 jmakowski1123 added the release blocker Blocks the upcoming release (fix needed) label Oct 23, 2025
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review October 23, 2025 19:49
@mariajgrimaldi
Copy link
Member Author

I have a unittest I need to push :)

@mariajgrimaldi mariajgrimaldi moved this from In Progress to Ready for review in RBAC AuthZ Board Oct 24, 2025
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/assign-lib-admin-role branch from 00dc12f to ede1472 Compare October 24, 2025 12:21
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@rodmgwgu rodmgwgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Oct 27, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Oct 27, 2025
@mariajgrimaldi mariajgrimaldi merged commit 31b1e6e into master Oct 29, 2025
53 checks passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/assign-lib-admin-role branch October 29, 2025 19:29
@github-project-automation github-project-automation bot moved this from Ready for review to Done in RBAC AuthZ Board Oct 29, 2025
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Oct 29, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Build-Test-Release Working Group Oct 29, 2025
mariajgrimaldi added a commit to eduNEXT/edx-platform that referenced this pull request Oct 30, 2025
haftamuk pushed a commit to haftamuk/edx-platform that referenced this pull request Nov 3, 2025
mariajgrimaldi added a commit to eduNEXT/edx-platform that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U release blocker Blocks the upcoming release (fix needed)

Projects

Archived in project
Status: Done

Development

Successfully merging this pull request may close these issues.

Bug: 403 when opening library dashboard as "guillermotest" team member

8 participants