Skip to content

Conversation

@farhaanbukhsh
Copy link
Member

@farhaanbukhsh farhaanbukhsh commented Oct 31, 2025

Ulmo sandbox requirements

ref: #37584

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 31, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @farhaanbukhsh!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Farhaan! Can you stick a changelog entry for ulmo.txt (and teak.txt) into the README in this directory (https://github.com/openedx/edx-platform/tree/master/requirements/edx-sandbox/README.rst) ? You can just follow the existing entries' pattern. I scanned the file and the only changes worth nothing is that SciPy went from 1.14 to 1.15 in Teak and 1.15 to 1.16 in Ulmo.

Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/update-sanbox-requirements branch from b00d7f3 to c1cfbf6 Compare November 2, 2025 06:21
@farhaanbukhsh
Copy link
Member Author

Thanks Farhaan! Can you stick a changelog entry for ulmo.txt (and teak.txt) into the README in this directory (https://github.com/openedx/edx-platform/tree/master/requirements/edx-sandbox/README.rst) ? You can just follow the existing entries' pattern. I scanned the file and the only changes worth nothing is that SciPy went from 1.14 to 1.15 in Teak and 1.15 to 1.16 in Ulmo.

Thanks for pointing it out @kdmccormick I have updated the file please have a look.

@farhaanbukhsh
Copy link
Member Author

@kdmccormick if this is good can we merge it?

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready to Merge in Contributions Nov 4, 2025
@mphilbrick211 mphilbrick211 moved this from Ready to Merge to In Eng Review in Contributions Nov 4, 2025
@feanil feanil dismissed kdmccormick’s stale review November 5, 2025 20:32

The request has been addressed.

@feanil
Copy link
Contributor

feanil commented Nov 5, 2025

I think this is good to merge.

@farhaanbukhsh farhaanbukhsh merged commit 810ea30 into master Nov 6, 2025
53 checks passed
@farhaanbukhsh farhaanbukhsh deleted the farhaan/update-sanbox-requirements branch November 6, 2025 14:01
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Nov 6, 2025
@farhaanbukhsh
Copy link
Member Author

Thanks @feanil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants