Skip to content

Conversation

@navinkarkera
Copy link
Contributor

Description

Fixes the issue where a container was not displayed as ready to sync when a descendent component is deleted in library

Useful information to include:

  • Which edX user roles will this change impact? "Course Author"

Supporting information

Testing instructions

Verify that the bug described in https://tasks.opencraft.com/browse/FAL-4270 is fixed.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 4, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 4, 2025

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 4, 2025
@navinkarkera navinkarkera marked this pull request as ready for review November 4, 2025 15:18
@navinkarkera navinkarkera changed the title fix: mark container as ready to sync if any child block is deleted fix: mark container as ready to sync if any child block is deleted [FC-0112] Nov 4, 2025
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will wait for the review of @rpenido to merge

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Nov 4, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Nov 4, 2025
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @navinkarkera!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

This is ready for merge @ChrisChV!

@ChrisChV
Copy link
Contributor

ChrisChV commented Nov 4, 2025

@navinkarkera could you squash this to fix the broken coverage?

Before this fix, if only a component is deleted, then its parent blocks
were not marked as ready to sync.
@navinkarkera navinkarkera force-pushed the navin/fal-4270/fix-delete-sync branch from f2970c1 to 2cd852b Compare November 5, 2025 04:46
@navinkarkera navinkarkera enabled auto-merge (rebase) November 5, 2025 04:47
@navinkarkera navinkarkera merged commit f2f0d87 into openedx:master Nov 5, 2025
48 checks passed
@navinkarkera navinkarkera deleted the navin/fal-4270/fix-delete-sync branch November 5, 2025 05:06
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants