refactor: Move upload/delete transcript into video_config service #37657

kdmccormick · 2025-11-19T19:26:22Z

Description

This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282

Testing instructions

Go to studio, and in a course, add a transcript, and delete it.
Do the same in a v2 library.

open-craft-grove · 2025-11-24T13:49:03Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-11-24T15:32:34Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-11-24T16:03:59Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

farhan · 2025-11-25T06:19:25Z

Transcripts are not uploading in the content library

openedx/core/djangoapps/video_config/services.py

xmodule/video_block/video_handlers.py

open-craft-grove · 2025-12-03T07:28:15Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-12-03T08:26:43Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-12-03T14:06:04Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction: openedx#36282

open-craft-grove · 2025-12-05T13:41:03Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-12-05T15:07:17Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-12-05T15:37:32Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Low-level apps should not depend on high-level apps

farhan · 2025-12-10T10:20:37Z

Transcripts are not uploading in the content library

Issue has been tested and its fixed now.

farhan · 2025-12-10T10:31:20Z

Following testing is done on the sandbox.
Go to studio, and in a course, add a transcript, and delete it.
Do the same in a v2 library.

open-craft-grove · 2025-12-10T11:33:54Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

feanil

Generally looks good to me, one small thing to fix.

Also, I don't see it on here, can you outline what testing you have done already on this change?

openedx/core/djangoapps/xblock/runtime/runtime.py

open-craft-grove · 2025-12-16T09:52:42Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

farhan · 2025-12-16T13:18:50Z

Here are my testing notes:

Testing on LMS/Studio:

A. Uploading transcript

Go to any course, add a video (youtube video) into the course
Add the transcript via settings
Transcript should be uploaded successfully
Transcript should render successfully on the studio
Publish the course
Video Block and transcript should render successfully on the LMS

B. Deleting transcript

After performing above steps, now delete the transcript from the video block.
Transcript should be deleted successfully and should stop appearing on the studio.
Publish the course.
Transcript should stop appearing on the lms as well

Testing on Content Library (Beta/V2):

C. Uploading transcript

Go to any content library > Units tab

Create a new unit and video block as a content in the unit.

Save the video and then edit the video again to upload/add the transcript. Transcript should be uploaded/added successfully.

Video and transcript should be render successfully in the content library preview.
Go to any course, Add the block/unit from the library via 'Use unit from library' button
Transcript should render successfully on the studio
Publish the course transcript should render successfully on the studio

D. Deleting transcript

After performing above steps, now delete the transcript from the video block in the content library.
Transcript should be deleted successfully in the content library preview.
Sync the block in the course with the content library version.
Transcript should stop appearing on the course as well.
Publish the course.
Transcript should stop appearing on the lms as well

farhan · 2025-12-16T14:37:20Z

🐛 BUG
From the testing notes mentioned in this comment (D point)
Deleting transcript on the Content Library Video Unit is note reflecting the changes correctly on the Course.

Content library video block after transcript deletion

Course video block added from content library and synced up successfully but still showing transcript which is a bug.

Further notes on it:
It exits on master and on this commit as well which is before moving transcript methods to the video service, so it needs to be fixed separately.

cc: @feanil @kdmccormick @openedx/axim-aximprovements @FuaadZam

open-craft-grove · 2025-12-17T16:27:56Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-12-18T12:51:27Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

farhan · 2025-12-19T10:26:17Z

Testing Notes:

Uploading transcript on the component/block of the Content library is not working fine on the sandbox of this PR.
It's working fine on Farhan/Irtaza and Kyle's local machine setup (having dev and local tutor setups)

As per discussion with @kdmccormick we tried testing of this PR in a fresh new PR here, created the sandbox and its working fine on new PR sandbox which means there is some data or sandbox-creation issue on this PR.

So I am closing this PR on account of this new PR

kdmccormick changed the title ~~refactor: Move upload/delete transcript int video_config service~~ refactor: Move upload/delete transcript into video_config service Nov 19, 2025

kdmccormick force-pushed the kdmccormick/upload-delete-transcript branch 3 times, most recently from b27c671 to 097c430 Compare November 20, 2025 04:45

kdmccormick marked this pull request as ready for review November 20, 2025 04:45

kdmccormick requested review from farhan, irtazaakram and salman2013 as code owners November 20, 2025 04:45

kdmccormick mentioned this pull request Nov 20, 2025

Move learning core methods to video config service #37634

Closed

kdmccormick force-pushed the kdmccormick/upload-delete-transcript branch from 696e7df to a738d26 Compare November 20, 2025 16:42

farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 24, 2025

farhan requested changes Nov 25, 2025

View reviewed changes

openedx/core/djangoapps/video_config/services.py Show resolved Hide resolved

openedx/core/djangoapps/video_config/services.py Outdated Show resolved Hide resolved

farhan reviewed Nov 25, 2025

View reviewed changes

openedx/core/djangoapps/video_config/services.py Outdated Show resolved Hide resolved

farhan requested a review from feanil November 26, 2025 11:49

farhan reviewed Nov 26, 2025

View reviewed changes

xmodule/video_block/video_handlers.py Show resolved Hide resolved

farhan force-pushed the kdmccormick/upload-delete-transcript branch from d633e66 to 0e56827 Compare December 2, 2025 15:15

farhan force-pushed the kdmccormick/upload-delete-transcript branch from 0e56827 to c4561ed Compare December 3, 2025 12:42

kdmccormick added 2 commits December 5, 2025 18:08

refactor: Move upload/delete transcript int video_config service

8bff04b

This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction: openedx#36282

fix: respond with new edx_video_id if created by transcript upload

886a2ed

farhan force-pushed the kdmccormick/upload-delete-transcript branch from c4561ed to 886a2ed Compare December 5, 2025 13:08

chore: remove circular dependencies

6412637

farhan force-pushed the kdmccormick/upload-delete-transcript branch from d968f53 to 6412637 Compare December 5, 2025 14:55

fix: Ignore following broken contract

6f7891d

Low-level apps should not depend on high-level apps

farhan force-pushed the kdmccormick/upload-delete-transcript branch from 6c93bd4 to 6f7891d Compare December 10, 2025 08:44

farhan approved these changes Dec 11, 2025

View reviewed changes

feanil reviewed Dec 15, 2025

View reviewed changes

openedx/core/djangoapps/xblock/runtime/runtime.py Show resolved Hide resolved

chore: add comment about circular dependency

28071b4

farhan closed this Dec 17, 2025

farhan reopened this Dec 17, 2025

farhan closed this Dec 17, 2025

farhan reopened this Dec 17, 2025

chore: address change request

6232735

farhan added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Dec 17, 2025

Merge branch 'master' into kdmccormick/upload-delete-transcript

bee186a

farhan mentioned this pull request Dec 19, 2025

refactor: Move upload/delete transcript int video_config service #37793

Merged

farhan closed this Dec 19, 2025

farhan mentioned this pull request Jan 16, 2026

fix: video_config runtime service added when loading for xBlock #37900

Merged

refactor: Move upload/delete transcript into video_config service #37657

refactor: Move upload/delete transcript into video_config service #37657

Conversation

kdmccormick commented Nov 19, 2025

Description

Testing instructions

Uh oh!

open-craft-grove commented Nov 24, 2025

Uh oh!

open-craft-grove commented Nov 24, 2025

Uh oh!

open-craft-grove commented Nov 24, 2025

Uh oh!

farhan commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

open-craft-grove commented Dec 3, 2025

Uh oh!

open-craft-grove commented Dec 3, 2025

Uh oh!

open-craft-grove commented Dec 3, 2025

Uh oh!

open-craft-grove commented Dec 5, 2025

Uh oh!

open-craft-grove commented Dec 5, 2025

Uh oh!

open-craft-grove commented Dec 5, 2025

Uh oh!

farhan commented Dec 10, 2025

Uh oh!

farhan commented Dec 10, 2025

Uh oh!

open-craft-grove commented Dec 10, 2025

Uh oh!

feanil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

open-craft-grove commented Dec 16, 2025

Uh oh!

farhan commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing on LMS/Studio:

Testing on Content Library (Beta/V2):

Uh oh!

farhan commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content library video block after transcript deletion

Course video block added from content library and synced up successfully but still showing transcript which is a bug.

Uh oh!

open-craft-grove commented Dec 17, 2025

Uh oh!

open-craft-grove commented Dec 18, 2025

Uh oh!

farhan commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Notes:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

farhan commented Nov 25, 2025 •

edited

Loading

farhan commented Dec 16, 2025 •

edited

Loading

farhan commented Dec 16, 2025 •

edited

Loading

farhan commented Dec 19, 2025 •

edited

Loading