-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: Course search pill not cleared when text deleted. #37709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @Asespinel! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
feanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally makes sense to me, is three a reason for the spacing the way it is?
|
@Asespinel can you make this change, I think the PR will be good to merge after that. |
Co-authored-by: Feanil Patel <feanil@axim.org>
|
hello @feanil I just commited your suggestion, thanks for the review! |
|
@Asespinel feel free to tag me on the backport PR as well when you create it. |
* fix: Course search pill not cleared when text deleted * chore: fix spacing Co-authored-by: Feanil Patel <feanil@axim.org> --------- Co-authored-by: Feanil Patel <feanil@axim.org>
* fix: Course search pill not cleared when text deleted * chore: fix spacing Co-authored-by: Feanil Patel <feanil@axim.org> --------- Co-authored-by: Feanil Patel <feanil@axim.org>
* fix: Course search pill not cleared when text deleted * chore: fix spacing Co-authored-by: Feanil Patel <feanil@axim.org> --------- Co-authored-by: Feanil Patel <feanil@axim.org>
Problem
When users cleared the search bar and performed an empty search, the filter pill with the previous search term remained visible, even though all courses were correctly returned. This created a confusing UX where the UI state didn't match the actual search results.
Solution
Added a check in the search event handler to remove the
search_queryfilter when the search input is empty. Now when users clear the search bar and hit search/enter, the filter pill is properly removed.Changes
search_queryfilter when empty search is detectedTesting