Skip to content

Conversation

@Asespinel
Copy link
Contributor

Problem

When users cleared the search bar and performed an empty search, the filter pill with the previous search term remained visible, even though all courses were correctly returned. This created a confusing UX where the UI state didn't match the actual search results.

Solution

Added a check in the search event handler to remove the search_query filter when the search input is empty. Now when users clear the search bar and hit search/enter, the filter pill is properly removed.

Changes

  • Check if query is empty or contains only whitespace before performing search
  • Remove search_query filter when empty search is detected
  • Maintains expected behavior: pill clears when search bar is cleared and search is performed

Testing

2025-12-01 11-31-10

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 1, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @Asespinel!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally makes sense to me, is three a reason for the spacing the way it is?

@feanil
Copy link
Contributor

feanil commented Dec 3, 2025

@Asespinel can you make this change, I think the PR will be good to merge after that.

Co-authored-by: Feanil Patel <feanil@axim.org>
@Asespinel
Copy link
Contributor Author

hello @feanil I just commited your suggestion, thanks for the review!

@feanil feanil changed the title fix: Course search pill not cleared when text deleted fix: Course search pill not cleared when text deleted. Dec 3, 2025
@feanil feanil merged commit 957e254 into openedx:master Dec 3, 2025
49 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Dec 3, 2025
@feanil
Copy link
Contributor

feanil commented Dec 3, 2025

@Asespinel feel free to tag me on the backport PR as well when you create it.

Asespinel added a commit to eduNEXT/edx-platform that referenced this pull request Dec 8, 2025
* fix: Course search pill not cleared when text deleted

* chore: fix spacing

Co-authored-by: Feanil Patel <feanil@axim.org>

---------

Co-authored-by: Feanil Patel <feanil@axim.org>
feanil added a commit that referenced this pull request Dec 9, 2025
* fix: Course search pill not cleared when text deleted

* chore: fix spacing

Co-authored-by: Feanil Patel <feanil@axim.org>

---------

Co-authored-by: Feanil Patel <feanil@axim.org>
mraman-2U pushed a commit to mraman-2U/edx-platform that referenced this pull request Dec 24, 2025
* fix: Course search pill not cleared when text deleted

* chore: fix spacing

Co-authored-by: Feanil Patel <feanil@axim.org>

---------

Co-authored-by: Feanil Patel <feanil@axim.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants