-
Notifications
You must be signed in to change notification settings - Fork 4.2k
docs: instructor grading api spec #37743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: instructor grading api spec #37743
Conversation
|
Thanks for the pull request, @wgu-jesse-stewart! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
rodmgwgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just added a comment.
Also, I see that there are some Merge commits for syncing with master, I think we should rebase instead and remove those commits.
lms/djangoapps/instructor/docs/references/instructor-v2-grading-api-spec.yaml
Outdated
Show resolved
Hide resolved
I think that is what happens when syncing a branch in the github ui - I will avoid doing that in the future and be sure to squash and merge this PR |
…m/WGU-Open-edX/edx-platform into docs/37647-instructor-grading-api
lms/djangoapps/instructor/docs/decisions/0002-instructor-grading-api-spec.rst
Outdated
Show resolved
Hide resolved
lms/djangoapps/instructor/docs/references/instructor-v2-grading-api-spec.yaml
Outdated
Show resolved
Hide resolved
dwong2708
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
lms/djangoapps/instructor/docs/decisions/0001-course-info-api-spec.rst
Outdated
Show resolved
Hide resolved
lms/djangoapps/instructor/docs/decisions/0002-instructor-grading-api-spec.rst
Outdated
Show resolved
Hide resolved
lms/djangoapps/instructor/docs/decisions/0002-instructor-grading-api-spec.rst
Show resolved
Hide resolved
lms/djangoapps/instructor/docs/references/instructor-v2-course-info-spec.yaml
Outdated
Show resolved
Hide resolved
wgu-taylor-payne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like a reasonable structure and direction to me. Thanks for the write-up on this. @feanil did you want to weigh in on this?
feanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note, otherwise looks good to me as well. Feel free to add some more detail if it makes sense, but I don't think you need to block on me to merge this if you're happy with it.
|
|
||
| #. **OpenAPI Specification** | ||
|
|
||
| Maintain an OpenAPI specification at ``../references/instructor-v2-course-info-spec.yaml`` for initial schema documentation. This specification will not be included in the platform-wide API documentation at ``/api-docs/``. As the API is implemented, the live schema at ``/api-docs/`` serves as the source of truth for endpoint structure, schemas, and validation rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarification, this spec will be the point of reference during implementation but /api-docs/ is the source of truth for what is implemented? After implementation is complete, it will only be there as a historical reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil Correct - the spec guides implementation, but /api-docs/ is the source of truth for what's actually deployed.
I'd propose deleting the static spec file once the implementation is complete and the endpoints are live in /api-docs/. At that point it becomes outdated documentation that could confuse future developers. We can remove it as part of the final PR that completes the API implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, lets put that in the decision doc as well then I think you're good to merge.
feanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for re-review once the decision on the spec nuance is captured.
Issue: 37647
Description
docs: Add ADRs and OpenAPI specifications for Instructor Dashboard v2 API
This PR adds architectural decision records (ADRs) and OpenAPI specifications for the modernized Instructor Dashboard API endpoints. These documentation files provide the design rationale and technical contracts for the v2 API implementation.
Changes:
0001-course-info-api-spec.rst) - documents the design of existing consolidated course metadata endpointinstructor-v2-course-info-spec.yaml) - specification for existing course info and task listing endpoints0002-instructor-grading-api-spec.rst) - proposes RESTful grading operations with sync/async execution modelsinstructor-v2-grading-api-spec.yaml) - specification for proposed grading endpointsUser roles impacted:
Supporting information
Related to the Instructor Dashboard modernization effort. These documents establish the foundation for migrating instructor dashboard functionality to RESTful patterns and supporting MFE development.
Testing instructions
This is documentation only - no functional testing required. Reviewers should:
Deadline
None
Other information