Ensure that the original error gets preserved by the ErrorModule #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
I wonder if we really need the syntax_error if there is already an error message. I would venture to say that we don't even need to do the XML parsing if an error_msg is provided. It's purpose is entirely for import/export -- arguably the original purpose of this method.
Actually, what would make more sense is to write a completely separate classmethod for ErrorDescriptor that constructs the class from text input, rather than XML, and to use this for the module_render wrapper functionality. Leave the from_xml as it originally was.
Contributor
|
👍 |
Contributor
Author
Contributor
|
Yes, I like that change. Ship-it. |
Contributor
|
👍 with the change |
dianakhuang
added a commit
that referenced
this pull request
Jun 5, 2013
Ensure that the original error gets preserved by the ErrorModule
cpennington
added a commit
that referenced
this pull request
Jun 25, 2014
Updated github.txt commit hash for opaque-keys
doctoryes
pushed a commit
that referenced
this pull request
Sep 15, 2014
doctoryes
pushed a commit
that referenced
this pull request
Sep 23, 2014
downzer0
pushed a commit
that referenced
this pull request
Nov 17, 2014
downzer0
pushed a commit
that referenced
this pull request
Nov 18, 2014
downzer0
pushed a commit
that referenced
this pull request
Nov 21, 2014
chrisrossi
referenced
this pull request
in jazkarta/edx-platform
Dec 9, 2014
apolinario
added a commit
to overdrive-diy/edx-platform
that referenced
this pull request
Dec 12, 2014
prachi1705
added a commit
to kkux/edx-platform
that referenced
this pull request
Feb 6, 2019
prachi1705
pushed a commit
to kkux/edx-platform
that referenced
this pull request
Feb 18, 2019
prachi1705
pushed a commit
to kkux/edx-platform
that referenced
this pull request
Feb 20, 2019
prachi1705
added a commit
to kkux/edx-platform
that referenced
this pull request
Mar 4, 2019
prachi1705
added a commit
to kkux/edx-platform
that referenced
this pull request
Mar 4, 2019
prachi1705
pushed a commit
to kkux/edx-platform
that referenced
this pull request
Mar 4, 2019
mumarkhan999
pushed a commit
to mumarkhan999/edx-platform
that referenced
this pull request
Mar 4, 2019
FIX: remove caliper config
pomegranited
referenced
this pull request
in edx-olive/edx-platform-old
May 8, 2019
Fixed Javascript test suite issues.
yasir1brahim
referenced
this pull request
in yasir1brahim/edx-platform
Apr 19, 2021
Implemented Reviews Tab on lms Approved-by: Oksana Slusarenko
lpm0073
referenced
this pull request
in grid-synergy/edx-platform
Apr 27, 2021
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
* feat: add packages dir to .gitignore * Investigate exam redirect (openedx#2) * feat: remove exam redirect * feat: take control over exam instructions * refactor: use fedx code structure * fix: remove debug logging, remove redirect check Co-authored-by: Vladas Tamoshaitis <vladas.tamoshaitis@raccoongang.com> * Add state and reducer for check microfrontend_special_exams waffle flag (openedx#4) * feat: add state and reducer for check microfrontend_special_exams waffle flag * fix: rename special exams enabled flag * fix: rename reducer for setting special exams enabled flag * refactor: timer feature * feat(tests): extend tests + fix failing ones, fix quality * fix: revert removing package lock file Co-authored-by: Vladas Tamoshaitis <vladas.tamoshaitis@raccoongang.com> * fix: naming of waffle flag helpers to reflect relation with mfe * fix: change naming of the waffle flag * fix: revert remove package lock file * feat: switch to @edx npm package * fix: Remove redundant references from .gitignore * fix: add is_mfe_special_exams_enabled to courseMetadata.factory.js * fix: fix tests for 'Sequence' content wrapped in 'SequenceExamWrapper' Co-authored-by: Sagirov Eugeniy <sagirov19@gmail.com> Co-authored-by: Vladas Tamoshaitis <vladas.tamoshaitis@raccoongang.com> Co-authored-by: Sagirov Evgeniy <34642612+UvgenGen@users.noreply.github.com> Co-authored-by: Igor Degtiarov <igor.degtiarov@raccoongang.com>
10 tasks
iloveagent57
pushed a commit
that referenced
this pull request
Feb 26, 2024
lms now depends on frontend-app-learning; previously, the converse was true. Running `make dev.up.lms` will start the frontend-app-learning container. This change has been made for all Devstack frontends/backends. This is breaking in that `make dev.up.frontend-app-*` is no longer the best way to start a frontend from a clean state, since it will not start related backend service(s). Instead, the backend service should be started, which will cause all related frontend apps to be started as dependencies. See included ADR (#4) for more context. Also includes some doc updates related to this change. TNL-8407
iloveagent57
pushed a commit
that referenced
this pull request
Feb 26, 2024
…ntends (#815) This commit made it so frontend services were started as dependencies whenever LMS (or other services) were started. The increased number of Docker containers is causing resource depletion for at least one developer. As a short-term fix, we will revert this commit. This reverts most of commit 54fb57f, although it leaves in place the changes to docs/workflow.rst, as they are still relevant. It also keeps ADR #4, but amends it.
ktyagiapphelix2u
pushed a commit
to ktyagiapphelix2u/edx-platform
that referenced
this pull request
Jun 2, 2025
papphelix
pushed a commit
to papphelix/edx-platform
that referenced
this pull request
Nov 20, 2025
chore: bump edxval to 3.1.0 (openedx#37490)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For LMS-300
Before, we would blow away the error message that was passed into ErrorModule, which is not very useful for debugging the underlying problems. This pull request should ensure that we preserve the incoming error.
@brianhw @wedaly