WIP - Integrate visual styling into the course outline #4442
Conversation
There was a problem hiding this comment.
"this checklist" in the tip text does not make sense.
There was a problem hiding this comment.
Good catch. That was a bad cut-and-paste error. Unfortunately we don't have the true category display name at this point. I guess I have to pass it down to the xblock info as well.
|
@talbs I've created a sandbox and a test project that tries to exercise all the different states: http://studio.andy-armstrong.m.sandbox.edx.org/course/AndyA/PUB101/PUB101 I'm continuing to refine the HTML to better match your spec so it is pretty close now but still needs some tweaking. Something happened where I lost the 'is-published' class so I'll add that back tomorrow. |
|
@talbs @cahrens @explorerleslie @mhoeber I have an updated sandbox that is looking very close to the design. I've uploaded my test course again: http://studio.andy-armstrong.m.sandbox.edx.org/course/AndyA/PUB101/PUB101 I have a lot of tests to write/fix now... |
|
Here's a teaser
|
|
Hi @andy-armstrong this is looking so good! Thanks also for putting together the test project so we can see all the states easily. Couple of comments:
@talbs and @frrrances (I don't remember who worked on click-to-edit section names)...can we chat about the edit icons for this? One thing I'm noticing as this is coming together is the first thing my eye is drawn to on the outline now is the many, many pencils scattered all over, instead of the most important items, like status, etc. |
|
In talking with @talbs, the click to edit pencil icons will only display on hover soon, so you can ignore my previous comment. |
* sync up stateful class names * show status border/visual for subsections in collapsed and expanded states * hide new-centric actions and messages on collapsed items * show/hide content elements for outline containers based on collapsed states * button-new semantic changes and icon-padding visual tweaks * replaced draft-like icon to something not used for actions * refactored styling and markup for collapse/expand
|
@explorerleslie, thanks for the feedback. I think I've all of the things you've noted address (expanded section border widths/colors, section title/release status vertical alignment, and title edit button only shows on hover over a section/subsection's title). Once @andy-armstrong has his sandbox updated with the latest you should be able to see these. |
|
@explorerleslie @talbs @cahrens I've made a lot of improvements to the publishing logic but it is still not quite there. It should be much more efficient though, which should help alleviate the performance problems we've been seeing. I've kicked off a sandbox rebuild so that should be ready when you see this. |
|
Closing this PR in favor of a new one based directly on bulk-publishing that cherry-picks the work from @talbs and myself. |
STUD-1849