Skip to content

Conversation

@tymofij
Copy link
Contributor

@tymofij tymofij commented Jul 31, 2014

@cahrens @dan-f @auraz

After merging https://github.com/edx/edx-platform/pull/4425 rendering time of Justice course increased from 5.5 seconds to 8 seconds in my environment. This was caused by course graders being recomputed for each xblock. I propose we compute them just once.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better "if not graders"

@cahrens
Copy link

cahrens commented Aug 1, 2014

After my comment is addressed, 👍

@cahrens
Copy link

cahrens commented Aug 1, 2014

Looks good to merge, though I would prefer a squash.

tymofij added a commit that referenced this pull request Aug 1, 2014
@tymofij tymofij merged commit 31943e9 into bulk-publishing Aug 1, 2014
@tymofij tymofij deleted the tim/performance-graders-optimization branch August 26, 2014 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants