Skip to content

Conversation

@bradenmacdonald
Copy link
Contributor

This minor commit fixes an annoying UI bug with the individual due date extensions, mentioned to me by @sarina in #4868. Whenever an instructor clicked on the "Extensions" tab, the browser would scroll down. This was due to a div having id "view-extensions", conflicting with the tabs script which sets location.hash to "view-[current tab name]" in order to track the current tab.

This was done for OpenCraft ( cc @antoviaque ) and falls under their organization contributor agreement.

(The div with id "view-extensions" conflicts with the tab JS which sets location.hash to "view-x" in order to track the current tab)
@sarina
Copy link
Contributor

sarina commented Aug 20, 2014

@carsongee would you mind taking a look at this small PR when you get a chance?

@sarina
Copy link
Contributor

sarina commented Aug 20, 2014

👍 will merge once tests pass and Carson takes a quick look.

@carsongee
Copy link
Contributor

The view granted extensions portions seems to be broken here. I get a 400 and nothing is displayed. That isn't the case in master

@sarina
Copy link
Contributor

sarina commented Aug 20, 2014

@carsongee do you have a screenshot? Everything worked fine for me...

@carsongee
Copy link
Contributor

In master I get the nice table like so:
image
but in this branch it just flashes "loading" and disappears and in the test server I get:
[20/Aug/2014 13:00:22] "GET /courses/MITx/8.02r/2014_Spring/instructor/api/show_unit_extensions HTTP/1.1" 400 118

This is clicking the "List all students with due date extensions" button

@carsongee
Copy link
Contributor

and seeing:

Error getting due dates: Missing required query parameter(s) extensions.js:136

in the js console.

@carsongee
Copy link
Contributor

d'oh, wasn't paying close enough attention and missed the coffee file and didn't rebuild assets after switching branches. Sorry about that. 👍

@sarina
Copy link
Contributor

sarina commented Aug 20, 2014

:) thanks for debugging!

sarina added a commit that referenced this pull request Aug 20, 2014
Fix: inadvertent scroll when loading the instructor's extensions tab
@sarina sarina merged commit 06001ab into openedx:master Aug 20, 2014
@bradenmacdonald bradenmacdonald deleted the fix-idde-ui branch August 20, 2014 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants