Friendly error if invalid student is entered for due date extension #4906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@carsongee would you mind taking a look at this small PR when you get a chance? |
Contributor
There was a problem hiding this comment.
When making internationalized strings, please use variable names instead of placeholders to facilitate correct translation. Please see https://github.com/edx/edx-platform/blob/master/docs/en_us/developers/source/i18n.rst#use-named-placeholders
Contributor
|
👍 |
Contributor
|
👍 - could you please squash to 1 commit? Then I will merge. |
bradenmacdonald
force-pushed
the
fix-idde-invalid-student
branch
from
b008d32 to
c3abf32
Compare
Contributor
Author
|
Sure thing. Now squashed and rebased. |
sarina
added a commit
that referenced
this pull request
Aug 21, 2014
Friendly error if invalid student is entered for due date extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor commit fixes another problem with individual due date extensions mentioned to me by @sarina in #4868: Whenever an invalid student identifier was entered into any of the "student email/username" fields on the instructor "extensions" page, no error would be shown.
With this change, the instructor will get the friendly error message "Could not find student matching identifier"
This was done for OpenCraft ( cc @antoviaque ) and falls under their organization contributor agreement.