change registration code email and attachments, per product requirements #5361
Conversation
|
@asadiqbal08 @muhhshoaib can you do a quick review of this? The product team has asked me to change the content of the email produced when one buys registration codes. We need to merge this by noon on Wednesday to make this week's release. Thanks |
lms/envs/aws.py
Outdated
There was a problem hiding this comment.
should be blank line at end of file.
|
I have tested this branch locally and generated the invoice to see that the email templates are working fine. The Boychoy test was failing on Jenkins, i have started the manual test run for this PR. |
chrisndodge
force-pushed
the
cdodge/change-invoice-email-and-attachments
branch
from
328a4b2 to
3c3e21a
Compare
remove extra lines conditionalize address line 2
chrisndodge
force-pushed
the
cdodge/change-invoice-email-and-attachments
branch
from
3c3e21a to
0c72e37
Compare
|
Talked to @jzoldak about the failing bokchoy tests. He mentioned he's seen it in the past, but is not currently on the "known flakey tests" list. Merging with this in mind. |
…achments change registration code email and attachments, per product requirements
|
@chrisndodge FWIW I believe the test failure was actually due to #3747 which was merged and then maybe reverted? At any rate, it changed the dashboard.html template course section from "Current Courses" to "Courses" and the tests that failed are asserting on the esperanto translation of that string. |
|
Further explanation regarding the failing LanguageTests in a comment on #5355. |
No description provided.