Nick/dnm hint - do not merge, just using jenkins

[nparlante]

No description provided.

[openedx-webhooks]

Thanks for the pull request, @nparlante! I've created OSPR-133 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Supporting information that is good to add there is anything that can help Product understand the context for the PR - supporting documentation, edx-code email threads, timeline information ('this must be merged by XX date', and why that is), partner information (this is for a course on edx.org, for example), etc.

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

[sarina]

@nparlante do you hve login access to jenkins? because there is a jenkins job that runs commits (so you don't have to open a PR)

https://jenkins.testeng.edx.org/job/edx-all-tests-manual-commit/

[nparlante]

Hmm, thanks Sarina. I have a jenkins account. I think it is based on my
github account.

I'm using this scheme where I commit to the Stanford repo, and then
(ultimately) PR over to edx. So I think that means the "commit" way is
not going to work. Maybe there's a workaround where I commit to
stanford, and then paste the hash into some part of the jenkins UI and
it figures it out. I'll ask the Stanford folks.

Cheers,

Nick

On 10/8/14 5:22 PM, Sarina Canelake wrote:

@nparlante https://github.com/nparlante do you hve login access to
jenkins? because there is a jenkins job that runs commits (so you
don't have to open a PR)

https://jenkins.testeng.edx.org/job/edx-all-tests-manual-commit/

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/5530#issuecomment-58448070.

[nparlante]

FYI everyone: per discussion on hipchat, me pushing to this PR really is the way I'm running Jenkins, so er, nothing to see here!

[sarina]

@nparlante does this supercede #4788?

[nparlante]

@sarina Hey Sarina, I thought I replied in email, but I don't see it here. Anyway, yes, I'm cleaning up and finishing off 4788. Right now I'm just cleaning it up, getting tests to pass etc, so it's WIP. Ultimately I can make a new PR for it, or we can figure out a way for me to commit it back to 4788. Whichever way you all prefer.

[sarina]

@nparlante I think it will be fine for you to submit your ultimate PR on this, or even a new, PR. The comments on #4788 were overwhelmingly about style and test coverage, and less about functional issues with the code or design choices, so I don't think there is a lot of value in trying to reuse that PR as the comments will be outdated and inapplicable.

[nparlante]

There used to be 31 commits here. Now there is one.

[sarina]

@nparlante are you ready for review? please let me know when you want us to start looking at this.

[nparlante]

Thanks Sarina, you're pretty on top of things to ask before I ping you!

I am indeed about done with it. I'll ping you next week, plus I hear
you're coming out our way.

Cheers,

Nick

On 11/26/14 12:44 PM, Sarina Canelake wrote:

@nparlante https://github.com/nparlante are you ready for review?
please let me know when you want us to start looking at this.

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/5530#issuecomment-64708008.

[sarina]

Sounds great! & yep I'll be out for a few days the week prior to Christmas,
similar to last year. Excited to see everyone!

On Wed, Nov 26, 2014 at 6:57 PM, Nick Parlante notifications@github.com
wrote:

Thanks Sarina, you're pretty on top of things to ask before I ping you!

I am indeed about done with it. I'll ping you next week, plus I hear
you're coming out our way.

Cheers,

Nick

On 11/26/14 12:44 PM, Sarina Canelake wrote:

@nparlante https://github.com/nparlante are you ready for review?
please let me know when you want us to start looking at this.

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/5530#issuecomment-64708008.

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/5530#issuecomment-64727944.

[sarina]

Happy New Year! 🎊

How's it going? We're trying to estimate what work we're going to accomplish in the next 3 months. It would be good to be planful about this pull request, if possible. Along those lines, do you have an estimate as to when you think the code will be ready for review?

[nparlante]

Hey Sarina -- I'm actually super close. Maybe PR on Tue or so? Per your
suggestion, Ross Strader and some OLI folks have built a testing/demo
class to work out the feature, so that'll be good to submit as well. I
could make a new PR, or I could figure out how to have this one not say
"dnm" any more. What do you think?

Cheers,

Nick

On 1/9/15 1:41 PM, Sarina Canelake wrote:

Happy New Year! 🎊

How's it going? We're trying to estimate what work we're going to
accomplish in the next 3 months. It would be good to be planful about
this pull request, if possible. Along those lines, do you have an
estimate as to when you think the code will be ready for review?

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/5530#issuecomment-69403741.

[sarina]

Great news!

I think the best course will be to open a new PR, as this discussion isn't
super germane to the PR work :)

Be sure to include in the description a tarball of Ross's test course, and
if possible the spec document that you mentioned.

On Mon, Jan 12, 2015 at 1:31 AM, Nick Parlante notifications@github.com
wrote:

Hey Sarina -- I'm actually super close. Maybe PR on Tue or so? Per your
suggestion, Ross Strader and some OLI folks have built a testing/demo
class to work out the feature, so that'll be good to submit as well. I
could make a new PR, or I could figure out how to have this one not say
"dnm" any more. What do you think?

Cheers,

Nick

On 1/9/15 1:41 PM, Sarina Canelake wrote:

Happy New Year! 🎊

How's it going? We're trying to estimate what work we're going to
accomplish in the next 3 months. It would be good to be planful about
this pull request, if possible. Along those lines, do you have an
estimate as to when you think the code will be ready for review?

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/5530#issuecomment-69403741.

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/5530#issuecomment-69533673.

[sarina]

@nparlante closing this now, since the new PR is open!