Account settings page

[symbolist]

https://openedx.atlassian.net/browse/TNL-1499
https://openedx.atlassian.net/browse/TNL-1534

The "Connected Accounts" functionality will be implemented in a separate PR.

[symbolist]

@explorerleslie @catong @marcotuts The sandbox should meet all the requirements now. Please review: http://learnerprofile.m.sandbox.edx.org/

[catong]

@symbolist, please tag @srpearce. She is the writer for this feature and should also be tagged for any doc strings/UI review. Thanks!

[marcotuts]

This should have its own section outside of the //shared - course area I think. I would make a "// views - platform" section underneath shared - course

Additionally, this import might make sense to add to application-extend2.scss.mako since that's where the other platform level views are imported.

[marcotuts]

anytime there's a math operation on a css variable, our convention is to wrap these in parentheses. ($baseline*2) I'll note this when I see it on this PR.

[symbolist]

@catong @explorerleslie @marcotuts Sandbox is back up: http://userprofile.m.sandbox.edx.org/account/settings

[explorerleslie]

@symbolist where is the list of languages that you're using come from? is it a default python library? I'd prefer a list the same as the one we use in video transcript language selection:

[symbolist]

@explorerleslie Its this list: https://github.com/edx/edx-platform/blob/master/lms/envs/common.py#L1803

[explorerleslie]

@symbolist I see languages like LOLCATS, Pirate, and Dummy Language on the account settings page that aren't in the list that you sent me. Why is that? Can we use the same list as in Studio?

[marcotuts]

NIT: remove newline

[marcotuts]

@symbolist I continued my styling / FED feedback through this PR / branch - https://github.com/edx/edx-platform/pull/7400

In summary, the suggested changes including some naming conventions for class names, table of contents comments for the scss file, text alignment for the fields even in case of longer support strings, and the use of borders as visual separators instead of

---

tags

[explorerleslie]

@cptvitamin could you please do an accessibility review? Sandbox is http://userprofile.m.sandbox.edx.org/account/settings.

[cptvitamin]

this <label> element is not programmatically associated with the form field it relates to. Either the form field needs to be a child of the <label> or the <label> element needs a for= attribute that references the ID of the associated form field. Also, the <label> needs to be associated with the *field-message span that follows with an aria-describedby= attribute that references an ID associated with that <span>

[cptvitamin]

@symbolist @explorerleslie, I did a first pass at an accessibility review. Would love another pass at it once these changes are implemented.

[cahrens]

@andy-armstrong eventing test failure caused by change to default being "all_users". https://build.testeng.edx.org/job/edx-platform-all-tests-pr-flow/4160/testReport/junit/acceptance.tests.lms.test_learner_profile/DifferentUserLearnerProfilePageTest/test_different_user_private_profile/

[andy-armstrong]

There was a strange acceptance failure here so I'm going to kick off another build:

19:12:11 ERROR:util.models:String decompression failed. There may be corrupted data in the database: Incorrect padding
19:12:37 Build timed out (after 60 minutes). Marking the build as aborted.

https://build.testeng.edx.org/job/edx-platform-test-subset/40023/console

[andy-armstrong]

Jenkins, please test this

[andy-armstrong]

Jenkins, test this please

[cahrens]

All tests have passed, merging!

[andy-armstrong]

Yay!

[cahrens]

Look, it's a green checkmark!!