Fix var name issue #753
Closed
Fix var name issue #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to add a test for the "chunked" case? Line 177 and 178 can be removed, and there are a bunch of unused imports in this file (a plug for IntelliJ-- it points out unused variables and imports, including the typo you are fixing). |
Author
|
i.e., the blank line and the comment? isn't cleaning up a different PR altogether? |
|
I think removing unused local variables and unused imports can be part of this PR. But if you want to do it as a second one, that's fine. I am speaking about these lines-- Definitely would like to see a test that hits the chunking, if feasible. |
|
A couple other questions--
|
Author
|
Moving to PR against release |
Merged
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…ebug-view add a debug_request view that prints the request.
itsjeyd
referenced
this pull request
in open-craft/openedx-platform
Nov 24, 2016
updated polls xblock version on mcka
caesar2164
added a commit
to caesar2164/edx-platform
that referenced
this pull request
Feb 16, 2018
Unfork help modal
andrey-canon
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Jun 19, 2018
…-attempts-fix Proversity/problem attempts fix
DanielVZ96
referenced
this pull request
in open-craft/openedx-platform
Jan 31, 2024
#753) This doesn't make metrics-sending *work* under 3.5 (capture_output isn't supported on that version, for instance) but it does prevent the presence of the script from breaking instrumented make targets. As long as the script loads and the main method runs properly under 3.5, try/else blocks can handle any other incompatibilities. Some people still use Python 3.5 with devstack, possibly by accident, even though devstack is supposed to be on 3.8 now. Much of devstack works with 3.5, even if requirements can no longer be installed, so someone who has docker-compose installed externally and doesn't use a virtualenv may not notice the environment mismatch. While we'd like people to upgrade to 3.8, the metrics script should at least not break their workflow in the meantime, since it is optional. Also: Note python 3.8 requirement in README while I'm at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong var name causes django-chunked (> 10MB?) asset upload to fail.