Skip to content

Bump version of Problem Builder#7638

Merged
bradenmacdonald merged 1 commit intoopenedx:masterfrom
open-craft:problem-builder-version-bump
Apr 16, 2015
Merged

Bump version of Problem Builder#7638
bradenmacdonald merged 1 commit intoopenedx:masterfrom
open-craft:problem-builder-version-bump

Conversation

@bradenmacdonald
Copy link
Contributor

Description: This bumps the "Problem Builder" XBlock to the latest version that has been reviewed by the edX team, and includes the configuration settings necessary for authors to use it.

This will be the final version bump required for an upcoming Harvard course.

This version of Problem Builder includes:

  • Problem Builder ("Mentoring v2") - the edx-release branch, which only contains changes reviewed by both OpenCraft and the edX team. (See this PR)
  • Dashboard XBlock (part of Problem Builder)

There should be minimal consequences to this PR as it only affects a new XBlock not yet used in any courses.

Partner information: hosted on edx.org (Harvard)
Merge deadline: ASAP

Sandbox: http://sandbox2.opencraft.com:18010/

@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: http://openedx-webhooks.herokuapp.com/github/process_pr?repo=edx%2Fedx-platform&number=7638

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradenmacdonald You will also need to add it to https://github.com/edx/edx-platform/blob/97f0cf108f6bd96ad678c6b3a168163f179e3e7d/cms/envs/common.py#L856 to allow it to be addable to a unit, this only allows to get the migrations to run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoviaque Ah, thanks - good catch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be added to the LMS as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters, because all we need is for the tables to be created, and the cms and lms migrations are usually run together as part of paver update_db. But since the old mentoring was listed in both, and it could potentially be important in the future, I might as well add it in there too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I added it to the lms/envs/common.py. I just amended the commit with that one-line change.

@bradenmacdonald bradenmacdonald force-pushed the problem-builder-version-bump branch 2 times, most recently from a5c726d to a5c477e Compare April 16, 2015 06:19
@bradenmacdonald bradenmacdonald changed the title Bump version of Problem Builder (WIP) Bump version of Problem Builder Apr 16, 2015
@bradenmacdonald
Copy link
Contributor Author

@sarina This is the last chapter in the Problem Builder saga. Can you please review?

@bradenmacdonald bradenmacdonald force-pushed the problem-builder-version-bump branch from a5c477e to 513591f Compare April 16, 2015 18:57
@sarina
Copy link
Contributor

sarina commented Apr 16, 2015

👍 to merge once tests pass.

@bradenmacdonald
Copy link
Contributor Author

Thanks @sarina !

@bradenmacdonald
Copy link
Contributor Author

test this please

@bradenmacdonald
Copy link
Contributor Author

test this please

bradenmacdonald added a commit that referenced this pull request Apr 16, 2015
@bradenmacdonald bradenmacdonald merged commit 00db27b into openedx:master Apr 16, 2015
@bradenmacdonald bradenmacdonald deleted the problem-builder-version-bump branch April 16, 2015 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants