Add test for large asset upload #766
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
@jkarni I'd prefer we figure out why the upload tests fail on jenkins and modify them so they will work rather than skip them. I didn't have time to look into it before. Does it pass when run locally on Ubuntu? |
Contributor
There was a problem hiding this comment.
Don't need skipIf anymore
Removed unneeded imports. Also, can't set the name of a tempfile
Author
|
@jzoldak Jonah's commit is supposed to have fixed the jenkins issue, but I'm not sure how/why. Is there some project for a still more generalized solution, or should I go ahead and fix the merge issues/rebase? |
caesar2164
pushed a commit
to caesar2164/edx-platform
that referenced
this pull request
Feb 21, 2018
* stv/unfork/timed-problem: Split out timed problem
andrey-canon
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Jun 21, 2018
Hiding browse tab when an user is a member team
DanielVZ96
referenced
this pull request
in open-craft/openedx-platform
Jan 31, 2024
…oning) (#766) Provisioning was broken by commit d1edbe7/PR #758 because it introduced a second layer of make, which caused the now-inner make call to target `dev.print-container.%` to print debugging info that looked like `make[2]: Entering directory '/home/timmc/edx-repos/devstack'`. Calls to `dev.print-container.%` already used the `--silent` flag, which is correct to use here but is insufficient because it doesn't suppress printing of the current directory when a recursive make call is made. This commit adds `--no-print-directory` to all calls to that target as well as to the documented way to call the target. This was not caught by automated tests because they fail to set `-e` in bash; this will be addressed in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jzoldak @cahrens
skipOnJenkinsis an ugly hack, but just usingskipseems even worse. If any of you know of some prettier way of doing, I would love to get this hack out.