Skip to content

Remove network calls in tests #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wedaly merged 3 commits into from
Aug 23, 2013
Merged

Remove network calls in tests #773

wedaly merged 3 commits into from
Aug 23, 2013

Conversation

@lapentab
Copy link
Contributor

@lapentab lapentab commented Aug 22, 2013

No description provided.

@ghost ghost assigned wedaly Aug 22, 2013
wedaly
wedaly reviewed Aug 22, 2013
View reviewed changes
cms/djangoapps/contentstore/tests/test_contentstore.py Outdated
Copy link
Contributor

@wedaly wedaly Aug 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more style nitpick: this line is too long.

Try something like this:

 # At the top of the file
 from textwrap import dedent

# When setting the return value...
dedent("""
    XML string...
    goes here.
""").strip()

Copy link
Contributor Author

@lapentab lapentab Aug 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

lapentab and others added 2 commits August 22, 2013 09:28
@lapentab
Stylistic changes
d894a06
Merge branch 'master' into lapentab/fix_network_tests
42ac76c 
Conflicts:
	lms/djangoapps/courseware/tests/tests.py
@wedaly
Copy link
Contributor

wedaly commented Aug 23, 2013

@jzoldak I resolved merge conflicts, but once the build passes, I think this is good to merge. Objections?

wedaly pushed a commit that referenced this pull request Aug 23, 2013
Merge pull request #773 from edx/lapentab/fix_network_tests
d89279f 
Remove network calls in tests
@wedaly wedaly merged commit d89279f into master Aug 23, 2013
@wedaly wedaly deleted the lapentab/fix_network_tests branch August 23, 2013 16:07
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
@cpennington
Merge pull request openedx#773 from MITx/feature/rocha/legal-terms-up…
31c1581 
…date

Update Terms of Use and Privacy static pages
caesar2164 pushed a commit to caesar2164/edx-platform that referenced this pull request Mar 26, 2018
@stvstnfrd
Merge pull request openedx#773
f781613 
* stv/unfork/inline-analytics:
  Split out more inline analytics code
andrey-canon pushed a commit to eduNEXT/edx-platform that referenced this pull request Jun 19, 2018
Proversity/user delete api (openedx#773)
1798f81 
* freetext update

* Update rocketchat from 0.2.7 to 0.2.8

* UPD: sga update

* correcting version number

* Hiding browse tab when an user is a member team

* Update xblocks

* addressing PR comments

* UPD: ignore site theme object for microsite

* reverting fix: it results in overrides not working anymore

* LoginFailuresAdmin fix

* Improve rocket chat teams discussion

* Remove unnecessary code

* Update rocketchat xblock

* stash

* UPD: user_api can now delete users

* clleanup
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
@cdeery
fix: [AA-1076] show grade override notice (openedx#773)
edf9e58 
* fix: [AA-1076] show grade override notice

- Progress page indicates if a grade has been overridden
- add unit test
bradenmacdonald added a commit that referenced this pull request Apr 24, 2025
@navinkarkera @bradenmacdonald
@ChrisChV @pomegranited @rpenido @ormsbee
feat: support for syncing units from libraries to courses (#36553)
1cd73d1 
* feat: library unit sync
* feat: create component link only for component xblocks
* feat: container link model
* feat: update downstream api views
* feat: delete extra components in container on sync (not working)
* fix: duplicate definitions of LibraryXBlockMetadata
* test: add a new integration test suite for syncing
* feat: partially implement container+child syncing
* fix: blockserializer wasn't always serializing all HTML block fields
* feat: handle reorder, addition and deletion of components in sync

Updates children components of unit in course based on upstream unit,
deletes removed component, adds new ones and updates order as per
upstream.

* feat: return unit upstreamInfo and disallow edits to units in courses that are sourced from a library (#773)
* feat: Add upstream_info to unit
* feat: disallow edits to units in courses that are sourced from a library (#774)

---------

Co-authored-by: Jillian Vogel <jill@opencraft.com>
Co-authored-by: Rômulo Penido <romulo.penido@gmail.com>

* docs: capitalization of XBlock

Co-authored-by: David Ormsbee <dave@axim.org>

* refactor: (minor) change python property name to reflect type better

* fix: lots of "Tried to inspect a missing...upstream link" warnings

when viewing a unit in Studio

* docs: mention potential REST API for future refactor

* fix: check if upstream actually exists before making unit read-only

* chore: fix camel-case var

* fix: test failure when mocked XBlock doesn't have UpstreamSyncMixin

---------

Co-authored-by: Braden MacDonald <braden@opencraft.com>
Co-authored-by: Chris Chávez <xnpiochv@gmail.com>
Co-authored-by: Jillian Vogel <jill@opencraft.com>
Co-authored-by: Rômulo Penido <romulo.penido@gmail.com>
Co-authored-by: Braden MacDonald <mail@bradenm.com>
Co-authored-by: David Ormsbee <dave@axim.org>
UsamaSadiq pushed a commit that referenced this pull request May 14, 2025
@navinkarkera @bradenmacdonald
@ChrisChV @pomegranited @rpenido @ormsbee @UsamaSadiq
feat: support for syncing units from libraries to courses (#36553)
7896a58 
* feat: library unit sync
* feat: create component link only for component xblocks
* feat: container link model
* feat: update downstream api views
* feat: delete extra components in container on sync (not working)
* fix: duplicate definitions of LibraryXBlockMetadata
* test: add a new integration test suite for syncing
* feat: partially implement container+child syncing
* fix: blockserializer wasn't always serializing all HTML block fields
* feat: handle reorder, addition and deletion of components in sync

Updates children components of unit in course based on upstream unit,
deletes removed component, adds new ones and updates order as per
upstream.

* feat: return unit upstreamInfo and disallow edits to units in courses that are sourced from a library (#773)
* feat: Add upstream_info to unit
* feat: disallow edits to units in courses that are sourced from a library (#774)

---------

Co-authored-by: Jillian Vogel <jill@opencraft.com>
Co-authored-by: Rômulo Penido <romulo.penido@gmail.com>

* docs: capitalization of XBlock

Co-authored-by: David Ormsbee <dave@axim.org>

* refactor: (minor) change python property name to reflect type better

* fix: lots of "Tried to inspect a missing...upstream link" warnings

when viewing a unit in Studio

* docs: mention potential REST API for future refactor

* fix: check if upstream actually exists before making unit read-only

* chore: fix camel-case var

* fix: test failure when mocked XBlock doesn't have UpstreamSyncMixin

---------

Co-authored-by: Braden MacDonald <braden@opencraft.com>
Co-authored-by: Chris Chávez <xnpiochv@gmail.com>
Co-authored-by: Jillian Vogel <jill@opencraft.com>
Co-authored-by: Rômulo Penido <romulo.penido@gmail.com>
Co-authored-by: Braden MacDonald <mail@bradenm.com>
Co-authored-by: David Ormsbee <dave@axim.org>
marlonkeating pushed a commit that referenced this pull request Jul 15, 2025
@navinkarkera @bradenmacdonald
@ChrisChV @pomegranited @rpenido @ormsbee @marlonkeating
feat: support for syncing units from libraries to courses (#36553)
a609134 
* feat: library unit sync
* feat: create component link only for component xblocks
* feat: container link model
* feat: update downstream api views
* feat: delete extra components in container on sync (not working)
* fix: duplicate definitions of LibraryXBlockMetadata
* test: add a new integration test suite for syncing
* feat: partially implement container+child syncing
* fix: blockserializer wasn't always serializing all HTML block fields
* feat: handle reorder, addition and deletion of components in sync

Updates children components of unit in course based on upstream unit,
deletes removed component, adds new ones and updates order as per
upstream.

* feat: return unit upstreamInfo and disallow edits to units in courses that are sourced from a library (#773)
* feat: Add upstream_info to unit
* feat: disallow edits to units in courses that are sourced from a library (#774)

---------

Co-authored-by: Jillian Vogel <jill@opencraft.com>
Co-authored-by: Rômulo Penido <romulo.penido@gmail.com>

* docs: capitalization of XBlock

Co-authored-by: David Ormsbee <dave@axim.org>

* refactor: (minor) change python property name to reflect type better

* fix: lots of "Tried to inspect a missing...upstream link" warnings

when viewing a unit in Studio

* docs: mention potential REST API for future refactor

* fix: check if upstream actually exists before making unit read-only

* chore: fix camel-case var

* fix: test failure when mocked XBlock doesn't have UpstreamSyncMixin

---------

Co-authored-by: Braden MacDonald <braden@opencraft.com>
Co-authored-by: Chris Chávez <xnpiochv@gmail.com>
Co-authored-by: Jillian Vogel <jill@opencraft.com>
Co-authored-by: Rômulo Penido <romulo.penido@gmail.com>
Co-authored-by: Braden MacDonald <mail@bradenm.com>
Co-authored-by: David Ormsbee <dave@axim.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wedaly wedaly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lapentab @wedaly