Speed button know behaves like the volume button when tabbing forward or... #854
Conversation
ghost
assigned
|
@jmclaus I have checkout your branch, and ran it on the example course content-demos found at https://github.com/MITx/content-demos . Looking at a video (YouTube source) in both Chrome and Firefox I was not able to tab further than the speeds control. It kept going through all of the speeds, then closing, and the opening again and going through all of the speeds. The same happens in Studio. |
|
@valera-rozuvan Commit 3cc2cc9 fixes all the issues. Tested in Chrome/Firefox with LMS/CMS. |
|
@jmclaus Verified manually - it works very well! |
|
The code is well documented and easy to follow. There is however one issue that if more controls will be added, or the ordering of controls will change, then things might break. For the developer to know that he broke something I think that this particular fix should be covered by Jasmine tests. |
|
Very good point. I will take care of it. |
|
@valera-rozuvan I added a Jasmine test that checks out the order of the controls and if there was an insertion of a new one. |
|
👍 Good to merge. Please do a |
… tabbing, in certain condition, would get stuck on speed button.
… tabbing on the speed control will malfunction if it is not the case.
…ontrol Speed button know behaves like the volume button when tabbing forward or...
Added an indicator on Progress page when there are no problem scores in a section.
…ix-requirement-version Fix requirements version openedx#854
yonk-729: urban airship push notification support
Rocket chat django app
* stv/content-visibility-warning: Move CONTENT_VISIBILITY_NOTICE to theme
Bump the default image reference for MongoDB from 4.2.17 to 4.2.24, to address a critical issue present in versions 4.2.0 through 4.2.23. References: https://www.mongodb.com/docs/manual/release-notes/4.2/#patch-releases https://jira.mongodb.org/browse/WT-10461 Fixes openedx#854.
This PR fixes the following issues in the video player:
The speed button was behaving differently than the volume button when tabbing through its elements (and was broken when tabbing backwards):
When going forward, we would traverse as follows: play/pause button, highest speed to lowest speed, volume button
When going backwards volume button, speed button, highest speed, speed button, highest speed etc.
We now have the following:
Forward: play/pause button, speed button, highest speed to lowest speed, speed button, volume button.
Backwards: volume button, speed button, lowest speed to highest speed, speed button, play/pause button.
This mirrors the behavior of the volume button.