fix bug with anonymous access to / with future start courses #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@shnayder mentioning you b/c of your comment at the top of student.views.index re: caching. |
Contributor
|
Nice. Looks good 👍 |
jbau
added a commit
that referenced
this pull request
Sep 13, 2013
fix bug with anonymous access to / with future start courses
macornwell
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Nov 23, 2017
MCKIN-5975 Updates to Problem Builder Swipe Component
DanielVZ96
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brianhw @shnayder
So this is one of those fixes where it was a 4 character fix but a much longer test.
One of the tests illustrates the problem, which is exercised when an anonymous user tries to access student.views.index (/) when there's a course with a future start date and MITX_FEATURES['DISABLE_START_DATES'] = False