Skip to content

Conversation

@sarina
Copy link
Contributor

@sarina sarina commented Oct 8, 2014

Follows on from error in #10

@singingwolfboy make sense?

@singingwolfboy
Copy link
Contributor

I thought that we wanted to synchronize labeling back to JIRA too, for specific labels? For example, you could add a "product review" label to a pull request, and it would move the JIRA ticket into the "Product Review" column. If that's the case, we shouldn't just ignore "labeled" events from github.

@sarina
Copy link
Contributor Author

sarina commented Oct 8, 2014

@singingwolfboy hmm. Can contributors add their own labels to PRs? Also, I'm wondering if that might be too confusing. I think one direction (jira -> github labels) may be sufficient, but am happy to be wrong on that.

OTOH, we can just merge this and address the reverse direction at a later time so we're not raising 400s

@singingwolfboy
Copy link
Contributor

You can only add a label to a pull request if you have write permissions on the repo, so no, our contributors can't do that. If you think one direction is sufficient, then I'm fine with that. As you way, we can always change this in the future.

singingwolfboy added a commit that referenced this pull request Oct 8, 2014
Ignore github labeling events
@singingwolfboy singingwolfboy merged commit 41fb942 into openedx:master Oct 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants