feat! Turn off survey link for merged/closed PRs #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kdmccormick is this right? |
kdmccormick
approved these changes
Aug 23, 2024
Co-authored-by: Kyle McCormick <me@kyle.app>
Member
|
@sarina I merged your PR, the only issue was commitlint wanted I'm not sure if this will autodeploy or if there's some step you need to do in order to deploy it. |
Contributor
Author
|
Oh thanks, I was thinking I had to make the other tests pass and hadn't looked into those yet. If it doesn't autodeploy I suppose we ask Feanil when he returns |
This was referenced Aug 27, 2024
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in standup, let's disable this for now until we have a better story around looking at the data and only posting on first-timers PRs