Add "Needs Triage" label to new PRs #9
Conversation
There was a problem hiding this comment.
Where is issue_url defined? And are you sure this is the URL for the Github issue, rather than the JIRA issue? Also, the API endpoint docs say that the labels attribute should be a list of strings, not a list of JSON objects: https://developer.github.com/v3/issues/#edit-an-issue
There was a problem hiding this comment.
o yes this is why code review is good. That means a lot of the stuff from #6 is broken too
There was a problem hiding this comment.
I suck at reading API doc apparently! sheesh. Um, what is "push access" and does the bot have it? Because remember how when you log in as edx-jira there's no "Merge" button? So perhaps edx-jira doesn't have push access, and that's why closing the PR from JIRA is failing, and would also mean changing these labels will fail.
There was a problem hiding this comment.
@sarina ah, that would make sense. Sounds like "push access" refers to permission levels for accounts: https://help.github.com/articles/permission-levels-for-an-organization-repository
There was a problem hiding this comment.
@singingwolfboy can you give botbro's account write access, then? I don't think I can, I'm not a Github admin
|
@singingwolfboy did we ever resolve whether or not we can give botbro write access to github? |
|
@sarina: Yes, the @edx-webhook user has write access to all the repos we care about. |
2 participants
@singingwolfboy god I hope this is the last thing I've overlooked.