[meta-oe] devtools/php: remove the failing ${D}/${TMPDIR} code#292
Closed
MaxKellermann wants to merge 1 commit intoopenembedded:masterfrom
Closed
[meta-oe] devtools/php: remove the failing ${D}/${TMPDIR} code#292MaxKellermann wants to merge 1 commit intoopenembedded:masterfrom
MaxKellermann wants to merge 1 commit intoopenembedded:masterfrom
Conversation
Appending ${TMPDIR} to ${D} doesn't make any sense, because both are
absolute paths. And additionally, the code fails:
rmdir: failed to remove '/usr/src/oe/tmp-musl/work/core2-64-oe-linux-musl/php/7.1.9-r0/image//usr': Directory not empty
Signed-off-by: Max Kellermann <max.kellermann@gmail.com>
Contributor
|
I guess you're seeing this issue because our TMPDIR starts with /usr while for most people it will be something line /home/foo or /OE etc which don't conflict with valid files in ${D}/usr But it made sense in 2013 when it was introduced https://git.openembedded.org/meta-openembedded/commit/?id=357915b6d11dfa612fbadaa4966a0b3e0f332467 and if php still does install files in this wrong location, then it still needs to be fixed not just reverted. |
Contributor
Author
|
If PHP installs files in those insane locations, then this bug should be patched in the PHP build system, instead of trying to fix it up after the fact. |
Contributor
agreed, it was just work around in 2013 and nobody sent patch to properly fix that since then |
Contributor
|
@MaxKellermann thanks, has this been tested in non /usr tmpdir env? |
Contributor
|
this has been merged via 5cd29d5 |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jun 5, 2023
Changelog:
==========
Fix openembedded#292: disuse HTTPResponse.strict
fix: double reading error on urllib3 2.0
Packaging the tests, or not
Add type annotations
Use Python's unittest mock
feat: remove compat module
tests: Support python 3.11
fix: use pytest native method name
Remove use of utcnow
Release 0.13.0
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 19, 2024
- switch to meson build system Changelog [1]: $ git --no-pager log --oneline v1.0.4..v1.0.5 098d985 (tag: v1.0.5) Merge pull request openembedded#312 from cgwalters/release 0fae8a8 Release 1.0.5 9bdc377 Merge pull request openembedded#310 from cgwalters/symlink-limit b06ea9b Verify payload length early on 3beb011 Merge pull request openembedded#308 from cgwalters/minor-rust-lints a695ad4 Merge pull request openembedded#309 from giuseppe/libcomposefs-drop-ro 0a0d50f libcomposefs: drop using "ro" option b35dc83 dumpfile: Fix clippy lint a919ab8 rust: Drop unused cfg 3a87868 Merge pull request openembedded#307 from giuseppe/not-override-errno bb94687 Merge pull request openembedded#306 from giuseppe/mkcomposefs-report-close-errors 76b4da5 mkcompose: report close() errors 502bc27 libcomposefs: do not override errno 2d2c09d Merge pull request openembedded#304 from jluebbe/meson 0260856 meson.build: Allow use as a meson subproject 5f512ac Merge pull request openembedded#303 from cgwalters/mount-source 91a3047 mount: Consistently use `composefs` as source 45e6179 Merge pull request openembedded#302 from cgwalters/info-term f64022f info: Add missing terminator for `longopts` d81cb87 Merge pull request openembedded#300 from jluebbe/meson 04c8a8e ci: Add GitHub Actions workflow which uses meson 64709f6 ci: Install meson package b6f2b75 Add meson as an alternative to autotools 942cd73 Merge pull request openembedded#299 from giuseppe/composefs-info-set-locale 5072fd7 composefs-info: specify locale to isgraph/isprint 4f19d00 Merge pull request openembedded#298 from cgwalters/rust-misc 43a1d28 rust: Add README.md files, link to crates.io a8bc747 rust: Clarify that "composefs-core" is really "composefs" 483356c Merge pull request openembedded#297 from cgwalters/rust-include 02213c0 composefs-core: Drop incorrect `include` dce84ff Merge pull request openembedded#295 from cgwalters/rust-descr 3d2af03 Merge pull request openembedded#296 from Kiskae/upstream-tmpdir-fix 6928fcf test: remove hardcoded /tmp e21be07 rust: Add mandatory `description` field, other misc changes 28dc491 Merge pull request openembedded#292 from cgwalters/rust-ci-dual 59c5a27 Merge pull request openembedded#293 from cgwalters/rust-minor 689ccc6 rust: Some doc and misc tweaks 426b65d ci: Test Rust code against current C code 32b3f6e Merge pull request openembedded#291 from Kiskae/patch-1 f7465b3 use correct `composefs-info` binary [1] composefs/composefs@v1.0.4...v1.0.5 Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 19, 2024
- switch to meson build system Changelog [1]: $ git --no-pager log --oneline v1.0.4..v1.0.5 098d985 (tag: v1.0.5) Merge pull request openembedded#312 from cgwalters/release 0fae8a8 Release 1.0.5 9bdc377 Merge pull request openembedded#310 from cgwalters/symlink-limit b06ea9b Verify payload length early on 3beb011 Merge pull request openembedded#308 from cgwalters/minor-rust-lints a695ad4 Merge pull request openembedded#309 from giuseppe/libcomposefs-drop-ro 0a0d50f libcomposefs: drop using "ro" option b35dc83 dumpfile: Fix clippy lint a919ab8 rust: Drop unused cfg 3a87868 Merge pull request openembedded#307 from giuseppe/not-override-errno bb94687 Merge pull request openembedded#306 from giuseppe/mkcomposefs-report-close-errors 76b4da5 mkcompose: report close() errors 502bc27 libcomposefs: do not override errno 2d2c09d Merge pull request openembedded#304 from jluebbe/meson 0260856 meson.build: Allow use as a meson subproject 5f512ac Merge pull request openembedded#303 from cgwalters/mount-source 91a3047 mount: Consistently use `composefs` as source 45e6179 Merge pull request openembedded#302 from cgwalters/info-term f64022f info: Add missing terminator for `longopts` d81cb87 Merge pull request openembedded#300 from jluebbe/meson 04c8a8e ci: Add GitHub Actions workflow which uses meson 64709f6 ci: Install meson package b6f2b75 Add meson as an alternative to autotools 942cd73 Merge pull request openembedded#299 from giuseppe/composefs-info-set-locale 5072fd7 composefs-info: specify locale to isgraph/isprint 4f19d00 Merge pull request openembedded#298 from cgwalters/rust-misc 43a1d28 rust: Add README.md files, link to crates.io a8bc747 rust: Clarify that "composefs-core" is really "composefs" 483356c Merge pull request openembedded#297 from cgwalters/rust-include 02213c0 composefs-core: Drop incorrect `include` dce84ff Merge pull request openembedded#295 from cgwalters/rust-descr 3d2af03 Merge pull request openembedded#296 from Kiskae/upstream-tmpdir-fix 6928fcf test: remove hardcoded /tmp e21be07 rust: Add mandatory `description` field, other misc changes 28dc491 Merge pull request openembedded#292 from cgwalters/rust-ci-dual 59c5a27 Merge pull request openembedded#293 from cgwalters/rust-minor 689ccc6 rust: Some doc and misc tweaks 426b65d ci: Test Rust code against current C code 32b3f6e Merge pull request openembedded#291 from Kiskae/patch-1 f7465b3 use correct `composefs-info` binary [1] composefs/composefs@v1.0.4...v1.0.5 Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jan 8, 2025
Changelog: * Update Unicode version 16.0 * Add new operator (*SKIP) * Fixed: ONIG_SYN_CONTEXT_INDEP_REPEAT_OPS not working for ^* pattern (Issue openembedded#292) Signed-off-by: Jason Schonberg <schonm@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
zboszor
pushed a commit
to zboszor/meta-openembedded
that referenced
this pull request
Sep 2, 2025
Changelog: * Update Unicode version 16.0 * Add new operator (*SKIP) * Fixed: ONIG_SYN_CONTEXT_INDEP_REPEAT_OPS not working for ^* pattern (Issue openembedded#292) Signed-off-by: Jason Schonberg <schonm@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
zboszor
pushed a commit
to zboszor/meta-openembedded
that referenced
this pull request
Dec 5, 2025
Changelog: * Update Unicode version 16.0 * Add new operator (*SKIP) * Fixed: ONIG_SYN_CONTEXT_INDEP_REPEAT_OPS not working for ^* pattern (Issue openembedded#292) Signed-off-by: Jason Schonberg <schonm@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appending ${TMPDIR} to ${D} doesn't make any sense, because both are
absolute paths. And additionally, the code fails:
rmdir: failed to remove '/usr/src/oe/tmp-musl/work/core2-64-oe-linux-musl/php/7.1.9-r0/image//usr': Directory not empty
Signed-off-by: Max Kellermann max.kellermann@gmail.com
(This is the successor of #66 which I cannot update because I had deleted my fork long ago. @kraj)