ExprTk: Update package to release/0.0.2 by ArashPartow · Pull Request #657 · openembedded/meta-openembedded

ArashPartow · 2023-02-16T11:32:29Z

Updates include:

Runtime checks to expression
Stackoverflow protections during compilation and expression evaluation
Various evaluation performance improvements

ArashPartow · 2023-02-16T11:33:23Z

@kraj when you have a moment can you please review and merge this PR

kraj

Thanks for your patch. It looks ok, except that patch subject should follow the commit guidelines [1], see section Patch Headers and Commit Messages

[1] https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

ArashPartow · 2023-02-16T21:38:21Z

@kraj I've updated the commit message and added some notes

geissonator · 2023-02-17T18:32:28Z

Ahh, we just hit this over in openbmc. Did we lost the previous commit (force push into master?) We can't build the previous recipe anymore.

shr-project · 2023-02-17T18:38:16Z

Looks like the commit really disappeared :( force pushing to publicly consumed branch is bad practice (I do it all the time for my personal branches, but nobody should be using them from upstream).

martin@jama /OE/exprtk $ git branch -a --contains 281c2ccc65b8f91c012ea3725ebcef406378a225
error: no such commit 281c2ccc65b8f91c012ea3725ebcef406378a225

martin@jama /OE/exprtk $ git branch -a --contains f46bffcd6966d38a09023fb37ba9335214c9b959
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
  remotes/origin/release

I was curious what changed and as I still had old version of master on PREMIRROR I've forked it and pushed as old-master:
https://github.com/ArashPartow/exprtk/compare/master...shr-project:exprtk:old-mster?expand=1

@geissonator that's why PREMIRRORs (and their snapshots) are pretty much mandatory for any serious project with reproducible builds.

kraj · 2023-02-17T19:04:36Z

I usually cherry-pick from github PRs into master-next for CI purpose, so its there on master-next https://git.openembedded.org/meta-openembedded/log/?h=master-next

Can you check if its still the same ?

geissonator · 2023-02-17T19:10:33Z

Fix over in master-next at https://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=98323c08a76cf54d0dd6a0c279c3c3e14494c04a looks good to me. Thanks!

ArashPartow · 2023-02-17T23:02:40Z

Apologies all for the confusion. The release branch is intended to be clean and will not have force pushes done on it. I also agree with @shr-project that snapshots are a good idea for reproducible build use-cases.

kraj · 2023-02-23T15:56:53Z

This is now in master - 0522e66

Use PACKAGE_BEFORE_PN which is designed to introduce packages before the final greedy ${PN}. Changes 1.24.0: Brad House (28): Nameserver parsing: replace another hand-written parser (openembedded#643) clang-format SonarCloud: silence bogus reported error ares_init_options() with invalid options values should unset the option Enable system extensions try to move AC_USE_SYSTEM_EXTENSIONS ares__round_up_pow2() work around bogus warning silence openwatcom warning due to qcache_max_ttl being unsigned Support ipv6 link-local servers and %iface syntax (openembedded#646) Windows UBSAN tests (openembedded#649) increment failures on timeout (openembedded#651) SonarCloud: make const enhance timeout test case enhance timeout test case to make sure it will re-use a previously downed server Rewrite sortlist hand parser for memory safety and bugs (openembedded#653) Clean up some Windows-only warnings (openembedded#654) clang-format and fix one warning remove redundant cast use IF_NAMESIZE instead of IFNAMSIZ to avoid warning Use external GoogleTest instead of bundling it (openembedded#655) remove dead code: bitncmp remove dead code: ares_iphlpapi.h Coverity: fix allocation size as reported in new code tag some functions as deprecated in docs reference alternative to ares_getsock() in docs 1.24.0 release prep (openembedded#657) rand: allow fallback from OS (openembedded#661) ares_cancel() could trigger callback with wrong response code (openembedded#663) Changes 1.23.0: Brad House (21): Query Cache support (openembedded#625) ares_set_servers_*() should allow an empty server list Fix Windows UWP (Store) building and add to CI/CD (openembedded#627) clang-format cleanup some Windows warnings in test fix additional windows test warnings CMake: CXXFLAGS environment wasn't being read because C++ compiler was enabled after settings warnings. now that warnings are enabled on test cases, clear a bunch of warnings fix test case regression due to missing parens SonarCloud: fix minor codesmells more precise timeout calculation (openembedded#633) environment is meant as an override for sysconfig Fix MacOS version test Basic Thread Safety (openembedded#636) fix ares_threadsafety() prototype ares_init_options with ARES_OPT_UDP_PORT wrong byte order fix doc typo remove a simply clang-format add missing manpage to distribution list 1.23.0 release prep (openembedded#641) Christian Clauss (2): INSTALL.md: Fix typo (openembedded#630) Fix typos discovered by codespell (openembedded#634) Daniel Stenberg (1): CI: codespell Ignat (1): Support attempts and timeout options from resolv.conf (openembedded#632) petrvh (1): ares_getaddrinfo(): do not use search domains if ARES_FLAG_NOSEARCH is set (openembedded#638) Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Use PACKAGE_BEFORE_PN which is designed to introduce packages before the final greedy ${PN}. Changes 1.24.0: Brad House (28): Nameserver parsing: replace another hand-written parser (#643) clang-format SonarCloud: silence bogus reported error ares_init_options() with invalid options values should unset the option Enable system extensions try to move AC_USE_SYSTEM_EXTENSIONS ares__round_up_pow2() work around bogus warning silence openwatcom warning due to qcache_max_ttl being unsigned Support ipv6 link-local servers and %iface syntax (#646) Windows UBSAN tests (#649) increment failures on timeout (#651) SonarCloud: make const enhance timeout test case enhance timeout test case to make sure it will re-use a previously downed server Rewrite sortlist hand parser for memory safety and bugs (#653) Clean up some Windows-only warnings (#654) clang-format and fix one warning remove redundant cast use IF_NAMESIZE instead of IFNAMSIZ to avoid warning Use external GoogleTest instead of bundling it (#655) remove dead code: bitncmp remove dead code: ares_iphlpapi.h Coverity: fix allocation size as reported in new code tag some functions as deprecated in docs reference alternative to ares_getsock() in docs 1.24.0 release prep (#657) rand: allow fallback from OS (#661) ares_cancel() could trigger callback with wrong response code (#663) Changes 1.23.0: Brad House (21): Query Cache support (#625) ares_set_servers_*() should allow an empty server list Fix Windows UWP (Store) building and add to CI/CD (#627) clang-format cleanup some Windows warnings in test fix additional windows test warnings CMake: CXXFLAGS environment wasn't being read because C++ compiler was enabled after settings warnings. now that warnings are enabled on test cases, clear a bunch of warnings fix test case regression due to missing parens SonarCloud: fix minor codesmells more precise timeout calculation (#633) environment is meant as an override for sysconfig Fix MacOS version test Basic Thread Safety (#636) fix ares_threadsafety() prototype ares_init_options with ARES_OPT_UDP_PORT wrong byte order fix doc typo remove a simply clang-format add missing manpage to distribution list 1.23.0 release prep (#641) Christian Clauss (2): INSTALL.md: Fix typo (#630) Fix typos discovered by codespell (#634) Daniel Stenberg (1): CI: codespell Ignat (1): Support attempts and timeout options from resolv.conf (#632) petrvh (1): ares_getaddrinfo(): do not use search domains if ARES_FLAG_NOSEARCH is set (#638) Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>

kraj reviewed Feb 16, 2023

View reviewed changes

ArashPartow changed the title ~~Update ExprTk package to release/0.0.2~~ ExprTk: Update package to release/0.0.2 Feb 16, 2023

ExprTk: Update package to release/0.0.2

39ba132

kraj closed this Feb 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ExprTk: Update package to release/0.0.2#657

ExprTk: Update package to release/0.0.2#657
ArashPartow wants to merge 1 commit intoopenembedded:masterfrom
ArashPartow:master

ArashPartow commented Feb 16, 2023 •

edited

Loading

Uh oh!

ArashPartow commented Feb 16, 2023

Uh oh!

kraj left a comment

Uh oh!

ArashPartow commented Feb 16, 2023

Uh oh!

geissonator commented Feb 17, 2023

Uh oh!

shr-project commented Feb 17, 2023 •

edited

Loading

Uh oh!

kraj commented Feb 17, 2023

Uh oh!

geissonator commented Feb 17, 2023

Uh oh!

ArashPartow commented Feb 17, 2023

Uh oh!

kraj commented Feb 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ArashPartow commented Feb 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ArashPartow commented Feb 16, 2023

Uh oh!

kraj left a comment

Choose a reason for hiding this comment

Uh oh!

ArashPartow commented Feb 16, 2023

Uh oh!

geissonator commented Feb 17, 2023

Uh oh!

shr-project commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kraj commented Feb 17, 2023

Uh oh!

geissonator commented Feb 17, 2023

Uh oh!

ArashPartow commented Feb 17, 2023

Uh oh!

kraj commented Feb 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ArashPartow commented Feb 16, 2023 •

edited

Loading

shr-project commented Feb 17, 2023 •

edited

Loading