image_types_sparse: Fix syntax error#725
Closed
chrisdimich wants to merge 1 commit intoopenembedded:mickledorefrom
chrisdimich:mickledore
Closed
image_types_sparse: Fix syntax error#725chrisdimich wants to merge 1 commit intoopenembedded:mickledorefrom chrisdimich:mickledore
chrisdimich wants to merge 1 commit intoopenembedded:mickledorefrom
chrisdimich:mickledore
Conversation
When using the image type: IMAGE_FSTYPES += " wic.sparse" IMAGE_CLASSES += " image_types_sparse" The following error arises: Syntax error: Bad function name So need to remove function in favor of variable. Signed-off-by: Chris Dimich <chris.dimich@boundarydevices.com>
shr-project
reviewed
Jul 28, 2023
| } | ||
|
|
||
| CONVERSION_CMD:sparse = " \ | ||
| truncate --no-create --size=%${SPARSE_BLOCK_SIZE} "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"; \ |
Contributor
There was a problem hiding this comment.
Does this even work in master (I see this PR is for mickledore, but if you're using this bbclass can you please check in master as well)?
I guess it needs to be updated for changes from:
https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c
first.
kraj
requested changes
Jul 30, 2023
Contributor
kraj
left a comment
kraj
left a comment
There was a problem hiding this comment.
Please port it to master first and then a backport into mickledore would be in order.
Author
|
Sure, I will port/test on master first. |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Nov 19, 2024
Changelog 1.28.1 :
This release contains a fix for a single significant regression introduced
in c-ares 1.28.0.
- ares_search() and ares_getaddrinfo() resolution fails if no search domains
are specified. Issue openembedded#737
Changelog 1.28.0 :
Features:
- Emit warnings when deprecated c-ares functions are used. This can be
disabled by passing a compiler definition of CARES_NO_DEPRECATED. PR openembedded#732
- Add function ares_search_dnsrec() to search for records using the new DNS
record data structures. PR openembedded#719
- Rework internals to pass around ares_dns_record_t instead of binary data,
this introduces new public functions of ares_query_dnsrec() and
ares_send_dnsrec(). PR openembedded#730
Changes:
- tests: when performing simulated queries, reduce timeouts to make tests run
faster
- Replace configuration file parsers with memory-safe parser. PR openembedded#725
- Remove acountry completely, the manpage might still get installed otherwise. Issue openembedded#718
Bugfixes:
- CMake: don't overwrite global required libraries/definitions/includes which
could cause build errors for projects chain building c-ares. Issue openembedded#729
- On some platforms, netinet6/in6.h is not included by netinet/in.h
and needs to be included separately. PR openembedded#728
- Fix a potential memory leak in ares_init(). Issue openembedded#724
- Some platforms don't have the isascii() function. Implement as a macro. PR openembedded#721
- CMake: Fix Chain building if CMAKE runtime paths not set
- NDots configuration should allow a value of zero. PR openembedded#735
Signed-off-by: Jason Schonberg <schonm@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Nov 20, 2024
Changelog 1.28.1 :
This release contains a fix for a single significant regression introduced
in c-ares 1.28.0.
- ares_search() and ares_getaddrinfo() resolution fails if no search domains
are specified. Issue openembedded#737
Changelog 1.28.0 :
Features:
- Emit warnings when deprecated c-ares functions are used. This can be
disabled by passing a compiler definition of CARES_NO_DEPRECATED. PR openembedded#732
- Add function ares_search_dnsrec() to search for records using the new DNS
record data structures. PR openembedded#719
- Rework internals to pass around ares_dns_record_t instead of binary data,
this introduces new public functions of ares_query_dnsrec() and
ares_send_dnsrec(). PR openembedded#730
Changes:
- tests: when performing simulated queries, reduce timeouts to make tests run
faster
- Replace configuration file parsers with memory-safe parser. PR openembedded#725
- Remove acountry completely, the manpage might still get installed otherwise. Issue openembedded#718
Bugfixes:
- CMake: don't overwrite global required libraries/definitions/includes which
could cause build errors for projects chain building c-ares. Issue openembedded#729
- On some platforms, netinet6/in6.h is not included by netinet/in.h
and needs to be included separately. PR openembedded#728
- Fix a potential memory leak in ares_init(). Issue openembedded#724
- Some platforms don't have the isascii() function. Implement as a macro. PR openembedded#721
- CMake: Fix Chain building if CMAKE runtime paths not set
- NDots configuration should allow a value of zero. PR openembedded#735
Signed-off-by: Jason Schonberg <schonm@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the image type:
The following error arises:
So need to remove function in favor of variable.