Skip to content

Test build multi-arch image in CI builds#843

Merged
alexellis merged 1 commit intoopenfaas:masterfrom
utsavanand2:github-actions
Dec 3, 2020
Merged

Test build multi-arch image in CI builds#843
alexellis merged 1 commit intoopenfaas:masterfrom
utsavanand2:github-actions

Conversation

@utsavanand2
Copy link
Copy Markdown
Contributor

Signed-off-by: Utsav Anand utsavanand2@gmail.com

Description

Test building multi-arch images in CI stage for testing.

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Check the build logs here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread .github/workflows/build.yaml Outdated
GIT_COMMIT=${{ github.sha }}
REPO_URL=https://github.com/${{ env.USER_REPO }}
tags: openfaas/faas-cli:${{ github.sha }}-root
tags: ghcr.io/openfaas/faas-cli:${{ github.sha }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was "openfaas/faas-cli" used anywhere in docker in scripts?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexellis I've changed it back to openfaas/faas-cli

Signed-off-by: Utsav Anand <utsavanand2@gmail.com>
Copy link
Copy Markdown
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 429edae into openfaas:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants