Upgrade versions and used Handler interface#193
Open
pmlopes wants to merge 1 commit intoopenfaas:masterfrom
pmlopes:update-vertx
Open
Upgrade versions and used Handler interface#193pmlopes wants to merge 1 commit intoopenfaas:masterfrom pmlopes:update-vertx
pmlopes wants to merge 1 commit intoopenfaas:masterfrom
pmlopes:update-vertx
Conversation
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Member
|
Hi @pmlopes thank you for this PR, please could you rebase? |
|
@pmlopes Like the idea of exposing the router. But Vert.x is now at 4.0.0. Are there reasons we dont want to use the latest 4.0.0? |
Author
|
@alexellis @jconlon This pr got lost on my side. Yes, we should upgrade it to 4.0.0. One of the improvements, application wize there should be almost to none code changes for the end user. We could change the style from callback to future/promise style which improves readability and internally guarantees that the thread affinity is always correct as the future object will enforce it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paulo Lopes pmlopes@gmail.com
The template was using an old version of vert.x and the handler should not implement the BodyHandler interface as it does not mean that you will get the HTTP body parsed. This needs to be passed on the bootstrap project and implement the vert.x Handler functional interface.
As a benefit this makes the function code smaller.
Still the original template or this PR do not expose the router to the function as a setup step. This would be interesting to chain middleware. As an example we could process CORS, or security before the function is executed.
Also post processing is not possible, for example a catch all error handler.