Improved Docker for Java 11 Template#202
Open
GoodforGod wants to merge 3 commits intoopenfaas:masterfrom
Open
Conversation
README fixed Gradle multi project improved and fixed (all unnecessary wrappers and settings removed) Gradle wrapper updated to 6.3 Sign-off-by: Anton Kurako <goodforgod.dev@gmail.com>
Sign-off-by: Anton Kurako <goodforgod.dev@gmail.com>
Sign-off-by: Anton Kurako <goodforgod.dev@gmail.com>
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
e814b10 to
44c4ddb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed base images to significatly reduce size of images, updated gradle, updated project gradle according to Gradle multi project guide lines. Improved bootstrap for function start up.
Description
Changed base image changed from just openJDK 11 to adoptopenjdk with alpine based images, thus it significantly reduces size of builder container and resulting image size from 250Mb (OpenJDK11) to 175Mb (AdoptOpenJDK Alpine Java 11) and for builder container from 562Mb for OpenJDK11 up to 401Mb for AdoptOpenJDK Alpine JDK 11.
Improved Gradle build flags to speed up build sequence.
Gradle wrapper for project itself updated to 6.3 and Gradle inside Docker updated to 6.3 to match each other.
Improved function start up time (bootstrap) by applying special java flags that can speed up application in case of serverless function.
Fixed README file version mistakes.
Motivation and Context
How Has This Been Tested?
Builded local function and
Types of changes
Impact to existing users
Gradle version in Docker container was 6.1 other wise, but it was old 4.8 as per project template itself (inconsistency between project and gradle build container), I propose consistency by updating all gradle up to 6.3
Checklist:
git commit -s