feat(import): allow to use tuples and tuple_file together#369
Merged
rhamzeh merged 5 commits intoopenfga:mainfrom Apr 21, 2025
Merged
feat(import): allow to use tuples and tuple_file together#369rhamzeh merged 5 commits intoopenfga:mainfrom
rhamzeh merged 5 commits intoopenfga:mainfrom
Conversation
32cdebc to
5110b2f
Compare
5110b2f to
1e6fda5
Compare
Member
|
@DanielBertocci thanks for this and apologies it took us so long to get to this - we'll be taking a closer look at this and adding tests. Thanks for your patience |
Member
|
Thanks @DanielBertocci - it does make sense to do this change, thank you for the suggestion and the PR. So as not to delay it, will merge it and we can update the docs after |
Member
|
We don't have great docs on the store file - we should create a The README should link to this file whenever it is discussing the format. Our VS Code and IntelliJ plugins should reference it in their own docs and our docs in openfga.dev should bundle it |
rhamzeh
approved these changes
Apr 21, 2025
Siddhant-K-code
approved these changes
Apr 21, 2025
This was referenced Apr 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current implementation on
fga store importsupports a configuration file with tuples and tuple_file fields.When tuple_file field is defined, all the tuples defined are ignored.
In this PR, I propose to join the tuples defined in the configuration file with the ones stored in the file set in tuple_file.
Allowing this, enables composition scenarios in which it is possible to share tuples between different store definitions.
Example
store_environment_a.yaml
store_environment_b.yaml
Review Checklist
main