Remove inline JavaScript. #2013
Open
+16
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running an inline script requires a website to have one of three things:
script-srcdirective in its content security policy (insecure).script-src 'unsafe-inline'(insecure).https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/CSP#inline_javascript
If we move the inline scripts into output.js, then websites can use a secure CSP without having to update it every time they want to publish a new Lime app.
Users can still call
lime.embed()manually if they want, in which case this will refrain from calling it again. This also means it's compatible with OpenFL's index.html template, so we can safely release this before updating that.