Fix icon and tooltip color in network detail view

[snappdevelopment]

The icons and tooltips in the network detail screen are black instead of white currently.
I removed the tint parameter, because it seems to be evaluated before the FloconIconButton, which is rendered inside, can overwrite it.
If you prefer a different solution, let me know or fix/close this PR :)

Before:

After:

[gemini-code-assist]

Summary of Changes

Hello @snappdevelopment, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a visual bug in the network detail view where icons and tooltips were incorrectly rendered in black instead of white. The fix involves refining the color application within the FloconIconButton component by removing an interfering tint parameter and directly specifying the correct text color for tooltips, thereby aligning the UI elements with the application's theme.

Highlights

• Icon Tinting Logic: The tint parameter was removed from the FloconIconButton composable function. This change addresses an issue where the explicit tint parameter was overriding the desired color, preventing inner components from correctly applying their own tint.
• Tooltip Color Correction: The Text component within the WithTooltip function now explicitly sets its color to FloconTheme.colorPalette.onSurface. This ensures that tooltips consistently display with the correct foreground color, resolving the issue of them appearing black.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where icons and tooltips in the network detail view were displayed with the wrong color. The fix for the icon color involves removing a tint parameter from FloconIconButton to allow it to correctly inherit the color from its parent composable. The tooltip text color is fixed by explicitly setting it. My review includes a suggestion to improve the semantic correctness of the tooltip color choice for better long-term maintainability.

[florent37]

thanks :)