fix: build jvm was broken

[florent37]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @florent37, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build issue, specifically for the JVM target, by introducing essential Ktor client and WebSocket related import statements. These additions ensure that the respective platform-specific client implementations have access to the required Ktor functionalities, resolving compilation errors and enabling robust network communication.

Highlights

• Ktor Client Imports: Added the io.ktor.client.request.header import to FloconHttpClient.ios.kt, FloconWebSocketClient.ios.kt, and FloconWebSocketClient.jvm.kt to enable proper header manipulation across different platforms.
• Ktor WebSocket Imports: Included necessary Ktor WebSocket plugin imports (DefaultClientWebSocketSession, WebSockets, webSocketSession) in FloconWebSocketClient.ios.kt to ensure correct WebSocket functionality on iOS.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a build failure by adding missing imports. The changes are accurate and resolve the issue. My review includes a few suggestions to improve import statements for consistency and adherence to best practices.

A more significant issue is the large amount of duplicated code between FloconWebSocketClient.ios.kt and FloconWebSocketClient.jvm.kt. The implementations are almost identical, differing only in the Ktor HttpClientEngine. This duplication is a high-priority maintainability concern. I strongly recommend refactoring this into a shared base class in commonMain in a follow-up pull request to reduce redundancy and prevent future bugs.