feat: Add BigDialog scene

[rteyssandier]

[gemini-code-assist]

Summary of Changes

Hello @rteyssandier, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new "BigDialog" scene type, significantly enhancing the application's navigation system. This addition enables the display of large, full-screen overlay dialogs, providing a dedicated and immersive user interface for content that requires more prominence than standard dialogs. The change integrates seamlessly into the existing navigation architecture, allowing for flexible and powerful UI presentations.

Highlights

• New BigDialog Scene: A new BigDialogScene component has been added, designed to display large, full-screen overlay dialogs within the application.
• BigDialogSceneStrategy Implementation: The BigDialogSceneStrategy has been implemented to manage the logic for when and how these large overlay dialogs are displayed, based on navigation entry metadata.
• Navigation Integration: The new BigDialogSceneStrategy has been integrated into the application's main navigation flow in AppScreen.kt, ensuring it is part of the scene strategy chain.

Changelog

• FloconDesktop/composeApp/src/commonMain/kotlin/io/github/openflocon/flocondesktop/app/AppScreen.kt
  • Imported BigDialogSceneStrategy for use in the application's main screen.
  • Chained BigDialogSceneStrategy into the existing sceneStrategy sequence, ensuring it's considered for navigation.
• FloconDesktop/navigation/src/commonMain/kotlin/io/github/openflocon/navigation/scene/BigDialogScene.kt
  • Created BigDialogScene as an OverlayScene to render a large, full-screen dialog with a top app bar and close action.
  • Defined BigDialogSceneStrategy to determine when a BigDialogScene should be displayed based on navigation entry metadata.
  • Included a companion object with a constant BIG_DIALOG and a helper function bigDialog() for metadata.

Activity

• No human activity (comments, reviews) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new BigDialogScene for the navigation system. The implementation is a good start, but there are a few issues in the new BigDialogScene.kt file that need to be addressed. I've pointed out a hardcoded title that limits reusability, an incorrect usage of FloconScaffold that violates a theming rule, and a logic bug in calculateScene that could lead to incorrect behavior or crashes. Please see my detailed comments for suggestions on how to fix these issues.

[gemini-code-assist]

The current logic using ?.let will create a BigDialogScene even if the BIG_DIALOG metadata property is explicitly false, as let executes for any non-null value. Additionally, lastEntry can be null, which would cause a problem when passed to BigDialogScene which expects a non-nullable NavEntry. This is likely a bug. The scene should only be created when the property is true. Using an if (dialogProperties == true) check would fix this bug and improve code clarity.

        val dialogProperties = lastEntry?.metadata?.get(BIG_DIALOG) as? Boolean
        return if (dialogProperties == true) {
            BigDialogScene(
                entry = lastEntry!!,
                previousEntries = entries.dropLast(1),
                overlaidEntries = entries.dropLast(1),
                onBack = onBack,
            )
        } else {
            null
        }