Add ADB Commander feature#503
Merged
rteyssandier merged 10 commits intoopenflocon:mainfrom Apr 5, 2026
Merged
Conversation
Contributor
Summary of ChangesHello @aldefy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the desktop application by integrating a robust ADB Commander feature. This new functionality empowers users to directly execute ADB commands, create and manage complex automation flows, and maintain a comprehensive history of their interactions, thereby streamlining device debugging and development workflows. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
Author
|
@florent37 Would you mind reviewing this PR? It implements #491 (ADB Commander feature). |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the comprehensive 'ADB Commander' feature, which is a significant and well-structured addition to the application. The implementation follows a clean architecture, separating concerns across domain, data, and UI layers. My review has identified a few key areas for improvement, primarily focusing on enhancing performance in data retrieval from the database, correcting a logic issue with timestamp updates, and improving state management within the ViewModel for better robustness. Addressing these points will further solidify the feature's foundation.
Contributor
rteyssandier
left a comment
rteyssandier
left a comment
There was a problem hiding this comment.
try to not use hardcoded strings
Contributor
|
@florent37 suggested to make a menu on the left, like for Database. Would be easier to switch between commands |
Contributor
Author
|
Great suggestion, will tackle the sidebar layout (like Database) as a follow-up. The current PR uses tabs, but a left panel with collapsible sections (Saved Commands, Flows, Quick Commands, History) alongside an always-visible console would be a better UX. Will open a separate issue/PR for this or would you prefer to have it planned on this PR? |
Contributor
Author
|
Just checking in if this PR needs any more changes , happy to fix/add changes |
Contributor
|
I like the feature honnestly, and it's easy to use, I'm just a bit concerned about the UX
---> again the UX of database, with a left pannel is better in term of lookalike and it goes with my 3rd and last point :
I think to fix all of these UX concerns, having the database lookalike with : is a good solution btw thanks a lot for this merge request <3 
|
Contributor
Author
Thanks , will push a fix for the changes today, was on a vaction missed the email updates |
Contributor
Author
|
New commit now adds it adb commander as a dashboard |
Contributor
|
thanks :) I'm testing and reviewing when I have time |
florent37
approved these changes
Apr 4, 2026
Contributor
|
better now :) you can rebase & merge when you want, I approved ! |
Adds a new ADB Commander screen to the desktop app with three tabs: - Runner: execute arbitrary ADB commands with console output - Library: saved commands, automation flows, and 47 built-in quick commands - History: timestamped log of all executed commands Supports automation flows (multi-step ADB command sequences with delays), works with or without a Flocon-paired device.
Use Room's @relation annotation to eagerly fetch flow steps instead of issuing a separate getFlowSteps query per flow.
Fetch existing entity before update to retain the original createdAt value for both saved commands and flows.
Replace mutable side-effect property with a dedicated StateFlow for more robust and predictable reactive state management.
Use 'in setOf()' for status checks and hoist SimpleDateFormat to a top-level val to avoid repeated instantiation.
Replace individual callback parameters with a single onAction: (AdbCommanderAction) -> Unit across all composables. ViewModel dispatches actions via onAction(action) method.
Move all user-facing strings in ADB Commander views to strings.xml for localization support.
Replace tab-based layout (Runner/Library/History) with a two-panel layout matching the Database feature: left panel (340dp) shows command library as expandable tree, right side shows prominent multi-line command input with toolbar and always-visible runner output. - Add CommandLibraryPanel with tree structure for saved commands, flows, and quick command categories - Add CommandInputView with toolbar (save/copy/history/clear) and multi-line input field with Cmd+Enter shortcut - Remove tab system entirely, history moves to toolbar dropdown - One-click command execution from library panel
aldefy
force-pushed
the
feat/adb-commander
branch
from
892ca59 to
67c5fea
Compare
Contributor
Author
|
Rebased , but guessing need that second review approval to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Test plan
shell echo hello→ Run → verify output in console