Make DashboardScope accept Flow instead of StateFlow#507
Make DashboardScope accept Flow instead of StateFlow#507rteyssandier merged 2 commits intoopenflocon:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the DashboardScope to accept Flow instead of StateFlow for section and form functions, making the API more flexible. The implementation is updated accordingly. I've included comments to address some now-unused imports for code cleanup.
|
|
||
| interface DashboardScope { | ||
| fun <T> section(name: String, flow: StateFlow<T>, content: SectionBuilder.(T) -> Unit) | ||
| fun <T> section(name: String, flow: Flow<T>, content: SectionBuilder.(T) -> Unit) |
There was a problem hiding this comment.
With StateFlow being replaced by Flow throughout this interface, the import kotlinx.coroutines.flow.StateFlow on line 6 is now unused and can be removed.
| * @param content The builder to construct the section content based on the data. | ||
| */ | ||
| override fun <T> section(name: String, flow: StateFlow<T>, content: SectionBuilder.(T) -> Unit) { | ||
| override fun <T> section(name: String, flow: Flow<T>, content: SectionBuilder.(T) -> Unit) { |
There was a problem hiding this comment.
With the changes in this file, StateFlow is no longer used. Please remove the unused import from line 13.
|
Fix gemini import discussion, and we should be good. |
|
@rteyssandier Thanks, I fixed it |
2 participants
The
sectionandformfunctions in theDashboardScopecurrently expect aStateFlow, but internally it is just used like a regularFlow. Sometimes the user has regular flows and it is a bit inconvenient to convert those to StateFlows, instead of just passing them directly tosection.