Skip to content

chore: add test-ci script for Travis to run instead of test#32

Merged
karrui merged 3 commits intomasterfrom
chore/test-ci
Jun 5, 2020
Merged

chore: add test-ci script for Travis to run instead of test#32
karrui merged 3 commits intomasterfrom
chore/test-ci

Conversation

@karrui
Copy link
Contributor

@karrui karrui commented Jun 4, 2020

Current test script may not be as useful for local devs since they might not have coveralls installed, resulting in an error (and undeleted .coverage folder):

Screenshot 2020-06-04 at 1 36 46 PM

Improvements

This PR:

  • renames the test script to test-ci and points Travis to run the script
  • adds back the old simpler test script for local test runs

@karrui karrui requested a review from liangyuanruo June 4, 2020 05:39
@karrui karrui requested a review from mantariksh June 5, 2020 02:11
Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@karrui karrui merged commit 71027f1 into master Jun 5, 2020
@karrui karrui deleted the chore/test-ci branch June 5, 2020 03:17
liangyuanruo pushed a commit that referenced this pull request Jan 27, 2021
* chore: rename test script to test-ci + update Travis to run ci script

* chore: add back old simpler test script

* chore: fix invalid Travis script npm command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants