test: add tests for new package initialisation#39
Merged
karrui merged 3 commits intofeat/class-based-verificationfrom Jun 8, 2020
Merged
test: add tests for new package initialisation#39karrui merged 3 commits intofeat/class-based-verificationfrom
karrui merged 3 commits intofeat/class-based-verificationfrom
Conversation
arshadali172
approved these changes
Jun 8, 2020
karrui
added a commit
that referenced
this pull request
Jun 11, 2020
* test: add tests for package initialisation * test: fix weird expected keys * test: add better comments for publicKey test
karrui
added a commit
that referenced
this pull request
Jun 11, 2020
* test: add tests for package initialisation * test: fix weird expected keys * test: add better comments for publicKey test
karrui
added a commit
that referenced
this pull request
Jun 11, 2020
* fix(errors): remove typo in error messages * refactor: move separate verification functions into utils file * refactor: move verification publicKey retrieval into publicKey util * feat: rewrite verification.ts functions as Verification class * refactor: use Verification class in package init * test: add verification/utils tests * test: rewrite verification tests to use new Verification class * feat: add check for malformed auth payload * test: add tests for new package initialisation (#39) * test: add tests for package initialisation * test: fix weird expected keys * test: add better comments for publicKey test
liangyuanruo
pushed a commit
that referenced
this pull request
Jan 27, 2021
* fix(errors): remove typo in error messages * refactor: move separate verification functions into utils file * refactor: move verification publicKey retrieval into publicKey util * feat: rewrite verification.ts functions as Verification class * refactor: use Verification class in package init * test: add verification/utils tests * test: rewrite verification tests to use new Verification class * feat: add check for malformed auth payload * test: add tests for new package initialisation (#39) * test: add tests for package initialisation * test: fix weird expected keys * test: add better comments for publicKey test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last!!!! part of the refactor, meant to keep the PR size manageable.
This PR adds tests for the new package initialisations.
Related to #31
The current chain is:
master -> webhooks -> crypto -> verification -> this