chore: Update JSDoc and print warning message if deprecated mode parameter is used#51
Merged
chore: Update JSDoc and print warning message if deprecated mode parameter is used#51
Conversation
…meter is used to initialize FormSG SDK
liangyuanruo
reviewed
Feb 1, 2021
liangyuanruo
approved these changes
Feb 1, 2021
Contributor
liangyuanruo
left a comment
liangyuanruo
left a comment
There was a problem hiding this comment.
Thanks, could you also help to update the readme to recommend the new initialisation method? Most developers copy the code there before using the SDK.
Co-authored-by: Yuan Ruo <yuanruo@data.gov.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46