add downloadAndDecryptAttachments for downloading and decrypting attachments#62
Merged
mantariksh merged 9 commits intodevelopfrom May 14, 2021
Merged
add downloadAndDecryptAttachments for downloading and decrypting attachments#62mantariksh merged 9 commits intodevelopfrom
mantariksh merged 9 commits intodevelopfrom
Conversation
mantariksh
reviewed
May 3, 2021
seaerchin
reviewed
May 4, 2021
Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
seaerchin
reviewed
May 5, 2021
mantariksh
reviewed
May 10, 2021
Contributor
|
will test this against your branch on the main repo before approving! |
mantariksh
reviewed
May 11, 2021
Contributor
mantariksh
left a comment
mantariksh
left a comment
There was a problem hiding this comment.
as discussed, we can remove the type annotations in the comments in the README code sample
mantariksh
previously requested changes
May 14, 2021
Contributor
mantariksh
left a comment
mantariksh
left a comment
There was a problem hiding this comment.
while testing on staging, I realised attachment fields are still disabled in the Build tab when the form has a webhook. we should remove that restriction.
mantariksh
dismissed
their stale review
whoops, left this comment in the wrong repo
mantariksh
approved these changes
May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for downloading and decrypting attachments sent via webhooks.
Corresponding client-side PR to opengovsg/FormSG#1713
Closes #60